Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] add ability to set GCName via runtimeconfig. #75159

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2022

Backport of #74831 to release/7.0

/cc @mangod9

Customer Impact

Add ability for customers to load standalone GC via runtime.config

Testing

The ability was already available via DOTNET_GCName environment variable. Manually validated that its honored if specified in runtime.config

Risk

Low, just adds support like other GC settings in config

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 6, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74831 to release/7.0

/cc @mangod9

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

Copy link
Member

@mrsharm mrsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Same changes from #74831 so we should be good to merge.

@carlossanlop
Copy link
Member

@jeffschwMSFT can we please get an approval?

@jeffschwMSFT jeffschwMSFT added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 6, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@jeffschwMSFT jeffschwMSFT removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 9, 2022
@carlossanlop
Copy link
Member

:shipit:

@carlossanlop carlossanlop merged commit 784974e into release/7.0 Sep 9, 2022
@carlossanlop carlossanlop deleted the backport/pr-74831-to-release/7.0 branch September 9, 2022 18:55
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants