-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] add ability to set GCName via runtimeconfig. #75159
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #74831 to release/7.0 /cc @mangod9 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Same changes from #74831 so we should be good to merge.
@jeffschwMSFT can we please get an approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Backport of #74831 to release/7.0
/cc @mangod9
Customer Impact
Add ability for customers to load standalone GC via runtime.config
Testing
The ability was already available via DOTNET_GCName environment variable. Manually validated that its honored if specified in runtime.config
Risk
Low, just adds support like other GC settings in config
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.