-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android #75458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
added
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
area-VM-reflection-mono
Reflection issues specific to MonoVM
labels
Sep 12, 2022
kotlarmilos
requested review from
steveisok,
SamMonoRT,
ivanpovazan and
jandupej
September 12, 2022 15:55
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
kotlarmilos
changed the title
[WIP][mono][tests] Testing disabled library tests on ARMv6 architecture
[mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android
Sep 15, 2022
kotlarmilos
removed
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Sep 15, 2022
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
Sep 19, 2022
ivanpovazan
reviewed
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
This was
linked to
issues
Sep 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix disabled library tests on ARMv6 and Android. Change test for
System.Runtime
to push int64 value instead of int32 value on evaluation stack.Related issues: