Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android #75458

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Sep 12, 2022

Fix disabled library tests on ARMv6 and Android. Change test for System.Runtime to push int64 value instead of int32 value on evaluation stack.

Related issues:

@kotlarmilos kotlarmilos added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-VM-reflection-mono Reflection issues specific to MonoVM labels Sep 12, 2022
@kotlarmilos kotlarmilos self-assigned this Sep 12, 2022
@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dnfadmin
Copy link

dnfadmin commented Sep 14, 2022

CLA assistant check
All CLA requirements met.

@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos changed the title [WIP][mono][tests] Testing disabled library tests on ARMv6 architecture [mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android Sep 15, 2022
@kotlarmilos kotlarmilos removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Sep 15, 2022
@kotlarmilos kotlarmilos marked this pull request as ready for review September 15, 2022 15:26
@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@kotlarmilos kotlarmilos merged commit b81654f into dotnet:main Sep 19, 2022
@kotlarmilos kotlarmilos deleted the issue-64675 branch September 19, 2022 16:13
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-reflection-mono Reflection issues specific to MonoVM
Projects
None yet
4 participants