Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android #75458

Merged
merged 7 commits into from
Sep 19, 2022
Merged

[mono][tests] Fix System.Reflection.Tests.ModuleTests.GetField failing test on ARMv6 and Android #75458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2685a5
push int64 instead of int32 on evaluation stack
kotlarmilos Sep 12, 2022
a32539e
Revert the test change
kotlarmilos Sep 13, 2022
2ab5af4
push int64 instead of int32 on evaluation stack
kotlarmilos Sep 14, 2022
a21f196
add ARMv6 pipeline
kotlarmilos Sep 15, 2022
809e960
add ARMv6 pipeline to runtime
kotlarmilos Sep 15, 2022
8f46f8f
add ARMv6 pipeline to runtime
kotlarmilos Sep 15, 2022
662f864
revert pipeline changes
kotlarmilos Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
push int64 instead of int32 on evaluation stack
  • Loading branch information
@kotlarmilos
kotlarmilos committed Sep 12, 2022
commit a2685a5760e94c39daaae7eb282b1b4b7d9f5d0d
2 changes: 0 additions & 2 deletions src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ public void GetField_NullName()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60558", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/64675", typeof(PlatformDetection), nameof(PlatformDetection.IsArmv6Process))]
public void GetField()
{
FieldInfo testInt = TestModule.GetField("TestInt", BindingFlags.Public | BindingFlags.Static);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime/tests/TestModule/System.Reflection.TestModule.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
{
ldc.i4.1
stsfld int32 TestInt
ldc.i4.2
ldc.i8 2
stsfld int64 TestLong
ret
}
Expand Down