PR feedback

- Add license banner to new files
- Change count to 0 for null VTables

src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/Marshalling/Base.cs

@@ -1,3 +1,6 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
 // Types for the COM Source Generator that define the basic vtable interactions and that we would need in the COM source generator in one form or another.
 namespace System.Runtime.InteropServices.Marshalling;
 

src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/Marshalling/Com.cs

@@ -1,3 +1,6 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
 // Types for the COM source generator that implement the COM-specific interactions.
 // All of these APIs need to be exposed to implement the COM source generator in one form or another.
 
@@ -322,4 +325,4 @@ public ComObject GetOrCreateUniqueObjectForComInstance(nint comInstance, CreateO
         }
         return (ComObject)GetOrCreateObjectForComInstance(comInstance, flags | CreateObjectFlags.UniqueInstance);
     }
-}
+}

src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/Marshalling/CommonStrategyImplementations.cs

@@ -1,3 +1,6 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
 // Implementations of the COM strategy interfaces defined in Com.cs that we would want to ship (can be internal only if we don't want to allow users to provide their own implementations in v1).
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;

src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/Marshalling/VTableExtensible.cs

@@ -1,3 +1,6 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
 // Types that are only needed for the VTable source generator or to provide abstract concepts that the COM generator would use under the hood.
 // These are types that we can exclude from the API proposals and either inline into the generated code, provide as file-scoped types, or not provide publicly (indicated by comments on each type).
 

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/GeneratedComInterfaceAnalyzerTests.cs

@@ -37,7 +37,7 @@ void Bar() {}
 
                     public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                     {
-                        protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                        protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                     }
 
                     """;
@@ -57,7 +57,7 @@ void Bar() {}
 
                     public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                     {
-                        protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                        protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                     }
 
                     """;
@@ -79,7 +79,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -100,7 +100,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -121,7 +121,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -142,7 +142,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -163,7 +163,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -184,7 +184,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -209,7 +209,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -235,7 +235,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -257,7 +257,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -279,7 +279,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -305,7 +305,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -331,7 +331,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -357,7 +357,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -383,7 +383,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -409,7 +409,7 @@ void Bar() {}
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -441,7 +441,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -465,7 +465,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -489,7 +489,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -517,7 +517,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -545,7 +545,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -573,7 +573,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -601,7 +601,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;
@@ -629,7 +629,7 @@ partial interface IFoo { }
 
                 public unsafe partial class MyComWrappers : GeneratedComWrappersBase
                 {
-                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 1; return null;}
+                    protected override ComInterfaceEntry* ComputeVtables(object obj, CreateComInterfaceFlags flags, out int count) {count = 0; return null;}
                 }
 
                 """;