-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new proposed API to Ancillary.Interop #81063
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
51539a7
Update API's and make minimum changes to build
jtschuster 3113a20
Update src/libraries/System.Runtime.InteropServices/tests/ComInterfac…
jtschuster 0f061fd
PR feedback
jtschuster e51c0d8
Merge branch 'vtableGenUpdate' of https://github.com/jtschuster/runti…
jtschuster 4b936c7
PR Feedback:
jtschuster d2cecc6
Update API's and make minimum changes to build
jtschuster 1403ae8
PR feedback
jtschuster b4205b4
Update src/libraries/System.Runtime.InteropServices/tests/ComInterfac…
jtschuster 046b9d1
PR Feedback:
jtschuster 65012f8
Passing tests - not cleaned; do not review
jtschuster 2cddf1c
Merge branch 'vtableGenUpdate' of https://github.com/jtschuster/runti…
jtschuster 53baeeb
Merge branch 'main' of https://github.com/dotnet/runtime into vtableG…
jtschuster 0d15662
Make unwrapperType optional
jtschuster f4afef5
Remove unused code, clean up comments, format
jtschuster 1599274
PR Feedback
jtschuster 3bb44a1
Pass unwrapper type through NativeThisInfo
jtschuster 8a4d125
Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
jtschuster 6d0198a
Update src/libraries/System.Runtime.InteropServices/gen/ComInterfaceG…
jtschuster e5b10e2
Update src/libraries/System.Runtime.InteropServices/gen/ComInterfaceG…
jtschuster e4529db
Use traditional namespace blocks
jtschuster 0356350
Add InternalsVisibleTo to Ancillary.Interop for VTableGenerator tests
jtschuster 9be677a
Make UnmanagedObjectUnwrapper internal
jtschuster b643733
Make types public instead of using InternalsVisibleTo
jtschuster c4f4cc0
Merge branch 'main' of https://github.com/dotnet/runtime into vtableG…
jtschuster d63a2da
Build xlf, add WrapperType to context
jtschuster 8cd216a
Update xlf
jtschuster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Build xlf, add WrapperType to context
- Loading branch information
commit d63a2da3fcd526447a1fe453ca6ae066af34c09c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,8 +207,9 @@ | |
<data name="InterfaceTypeNotSupportedMessage" xml:space="preserve"> | ||
<value>Using 'GeneratedComInterfaceAttribute' and 'InterfaceTypeAttribute' is not supported with 'ComInterfaceType' value '{0}'.</value> | ||
</data> | ||
<data name="InvalidAttributedMethodContainingTypeMissingUnmanagedObjectUnwrapperAttribute" xml:space="preserve"> | ||
<data name="InvalidAttributedMethodContainingTypeMissingUnmanagedObjectUnwrapperAttributeMessage" xml:space="preserve"> | ||
<value>Containing type of method with VirtualMethodIndexAttribute does not have a UnmanagedObjectUnwrapperAttribute. </value> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: single quote around type names |
||
</data> | ||
<data name="MethodNotDeclaredInAttributedInterfaceDescription" xml:space="preserve"> | ||
<value>All methods must be declared in the same partial definition of a 'GeneratedComInterface'-attributed interface type to ensure reliable calculation for virtual method table offsets.</value> | ||
</data> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for later change) We should probably have a different ID for the diagnostics here.