Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Enable PackedSimd in the interpreter; interpreter/jiterpreter v128 bug fixes #86136

Closed
wants to merge 25 commits into from

Conversation

kg
Copy link
Contributor

@kg kg commented May 12, 2023

  • Fix trimming only honoring WasmEnableSIMD if AOT was also enabled
  • Turn MINT_NIY back into a real opcode that asserts so we can use it as a replacement for unimplemented PackedSimd methods
  • Fix incorrect ordering in sri_vector128_t_methods
  • Fix missing names in sri_packedsimd_methods
  • When transforming a call to a PackedSimd method, always either produce a real implementation or a MINT_NIY so that it will fail in a sensible way instead of overflowing the stack
  • Implement V128_Ix_EXTRACT_MSB in the jiterpreter
  • New hopefully not broken V128_Ix_CREATE_SCALAR implementation in the jiterpreter

@kg kg added the arch-wasm WebAssembly architecture label May 12, 2023
@ghost
Copy link

ghost commented May 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fix trimming only honoring WasmEnableSIMD if AOT was also enabled
  • Turn MINT_NIY back into a real opcode that asserts so we can use it as a replacement for unimplemented PackedSimd methods
  • Fix incorrect ordering in sri_vector128_t_methods
  • Fix missing names in sri_packedsimd_methods
  • When transforming a call to a PackedSimd method, always either produce a real implementation or a MINT_NIY so that it will fail in a sensible way instead of overflowing the stack
  • Implement V128_Ix_EXTRACT_MSB in the jiterpreter
  • New hopefully not broken V128_Ix_CREATE_SCALAR implementation in the jiterpreter
Author: kg
Assignees: -
Labels:

arch-wasm

Milestone: -

@kg kg closed this May 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant