Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable PackedSimd in the interpreter; interpreter/jiterpreter v128 bug fixes #86136

Closed
wants to merge 25 commits into from
Closed

[wasm] Enable PackedSimd in the interpreter; interpreter/jiterpreter v128 bug fixes #86136

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
83497db
Enable v128 and wasm packedsimd in the interpreter
kg May 8, 2023
920362a
Test: Disable widen v128 intrinsics
kg May 8, 2023
da7fb58
Test: Disable extract msb
kg May 8, 2023
5919492
Re-enable disabled v128 operations; disable packedsimd
kg May 10, 2023
6c8f682
Disable all v128 intrinsics except the HardwareAccelerated bool
kg May 10, 2023
72203d0
Attempt to satisfy whatever configuration clang uses on CI
kg May 10, 2023
df4fee3
Unused variable
kg May 10, 2023
e6c55db
Suppress warning
kg May 10, 2023
c709a5a
Remove all the platforms except wasm
kg May 10, 2023
6c1b023
v128 intrinsic bisection step #1
kg May 10, 2023
41a89c0
v128 intrinsic bisection step #2
kg May 11, 2023
52af86f
v128 intrinsic bisection step 3
kg May 11, 2023
8b97246
v128 intrinsic bisection step 4
kg May 11, 2023
d9f8344
v128 intrinsic bisection step 5
kg May 11, 2023
750e494
v128 intrinsic bisection step 6
kg May 11, 2023
db8875d
v128 intrinsic bisection step 7
kg May 11, 2023
400127d
Re-enable stuff
kg May 11, 2023
3a8b2f6
Revert changes
kg May 12, 2023
1c123fd
Prepare for actual merge
kg May 12, 2023
fa63753
Fix (?) the create scalar intrinsics in the jiterpreter
kg May 12, 2023
70d072e
Add wasm opcode mapping for extract msb
kg May 12, 2023
be1d393
Various fixes
kg May 12, 2023
be16127
Better handling of unimplemented packedsimd methods
kg May 12, 2023
cf72be0
Enable PackedSimd
kg May 12, 2023
03d42f5
Checkpoint
kg May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better handling of unimplemented packedsimd methods
  • Loading branch information
@kg
kg committed May 12, 2023
commit be161275afefd65e7b63b37fda6758bc960ca437
19 changes: 5 additions & 14 deletions src/mono/mono/mini/interp/transform-simd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,15 +547,13 @@ static gboolean
emit_sri_packedsimd (TransformData *td, MonoMethod *cmethod, MonoMethodSignature *csignature)
{
int id = lookup_intrins (sri_packedsimd_methods, sizeof (sri_packedsimd_methods), cmethod);
if (id == -1)
return FALSE;
// We don't early-out for an unrecognized method, we will generate an NIY later

MonoClass *vector_klass = mono_class_from_mono_type_internal (csignature->ret);
int vector_size = -1;

if ((id == SN_get_IsSupported) || (id == SN_get_IsHardwareAccelerated)) {
#if HOST_BROWSER
g_print ("MONO interpreter: Returning constant %d: System.Runtime.Intrinsics.Wasm.PackedSimd.%s\n", mono_opt_interp_simd_packedsimd, cmethod->name);
interp_add_ins (td, mono_opt_interp_simd_packedsimd ? MINT_LDC_I4_1 : MINT_LDC_I4_0);
#else
interp_add_ins (td, MINT_LDC_I4_0);
Expand All @@ -564,8 +562,8 @@ emit_sri_packedsimd (TransformData *td, MonoMethod *cmethod, MonoMethodSignature
}

#if HOST_BROWSER
if (!mono_opt_interp_simd_packedsimd) {
g_print ("MONO interpreter: Disabled method: System.Runtime.Intrinsics.Wasm.PackedSimd.%s\n", cmethod->name);
if (!mono_opt_interp_simd_packedsimd || (id < 0)) {
g_print ("MONO interpreter: Disabled or unimplemented method: System.Runtime.Intrinsics.Wasm.PackedSimd.%s\n", cmethod->name);
// The packedsimd method implementations recurse infinitely and cause a stack overflow,
// so replace them with a NIY opcode instead that will assert
interp_add_ins (td, MINT_NIY);
Expand Down Expand Up @@ -733,15 +731,8 @@ interp_emit_simd_intrinsics (TransformData *td, MonoMethod *cmethod, MonoMethodS
else if (!strcmp (class_name, "Vector128`1"))
return emit_sri_vector128_t (td, cmethod, csignature);
} else if (!strcmp (class_ns, "System.Runtime.Intrinsics.Wasm")) {
if (!strcmp (class_name, "PackedSimd")) {
gboolean res = emit_sri_packedsimd (td, cmethod, csignature);
#if HOST_BROWSER
if (!res)
g_print ("MONO interpreter: Unsupported method: System.Runtime.Intrinsics.Wasm.PackedSimd.%s\n", cmethod->name);
g_assert (res);
#endif
return res;
}
if (!strcmp (class_name, "PackedSimd"))
return emit_sri_packedsimd (td, cmethod, csignature);
}
return FALSE;
}