Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreGenerateSatelliteAssemblies broken for all languages except C# #1748

Closed
tmeschter opened this issue Nov 16, 2017 · 0 comments · Fixed by #1749
Closed

CoreGenerateSatelliteAssemblies broken for all languages except C# #1748

tmeschter opened this issue Nov 16, 2017 · 0 comments · Fixed by #1749
Assignees
@tmeschter
Labels
Bug

Comments

@tmeschter
Copy link
Contributor

The CoreGenerateSatelliteAssemblies task first calls the WriteCodeFragment task to write a bunch of attributes to a .cs file, and then calls the Csc task to compile it (along with the .resource files, of course).

However, the call to WriteCodeFragment specifies the language of the code to generate using the $(Language) property, rather than always passing "C#". This means that in a VB project we'll end up generating VB code into a .cs file, which we then try to compile with csc.exe.

That isn't going to end well.
@tmeschter tmeschter added the Bug label Nov 16, 2017
@tmeschter tmeschter self-assigned this Nov 16, 2017
@tmeschter tmeschter mentioned this issue Nov 16, 2017
Closed
tmeschter added a commit to tmeschter/sdk that referenced this issue Nov 16, 2017
@tmeschter
Make CoreGenerateSatelliteAssemblies work for VB
c9931c3 
Fixes dotnet#1748.

The `CoreGenerateSatelliteAssemblies` task first calls the
`WriteCodeFragment` task to write a bunch of attributes to a .cs file,
and then calls the `Csc` task to compile it (along with the .resource
files, of course).

However, the call to `WriteCodeFragment` will use the project's language
to generate the source file. This means that in a VB project we'll end
up generating VB code into a .cs file which we then try to compile with
csc.exe. That doesn't end well.

The fix here is to always pass "C#" as the language to
`WriteCodeFragment`.
This was referenced Nov 16, 2017
Merged
Closed
nguerrera pushed a commit to nguerrera/sdk that referenced this issue Feb 26, 2018
@tmeschter @nguerrera
Make CoreGenerateSatelliteAssemblies work for VB
c40e5cf 
Fixes dotnet#1748.

The `CoreGenerateSatelliteAssemblies` task first calls the
`WriteCodeFragment` task to write a bunch of attributes to a .cs file,
and then calls the `Csc` task to compile it (along with the .resource
files, of course).

However, the call to `WriteCodeFragment` will use the project's language
to generate the source file. This means that in a VB project we'll end
up generating VB code into a .cs file which we then try to compile with
csc.exe. That doesn't end well.

The fix here is to always pass "C#" as the language to
`WriteCodeFragment`.
@nguerrera nguerrera mentioned this issue Feb 26, 2018
Merged
@nguerrera nguerrera mentioned this issue Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmeschter tmeschter

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CoreGenerateSatelliteAssemblies work for VB tmeschter/sdk
1 participant
@tmeschter