Make CoreGenerateSatelliteAssemblies work for VB #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#1748. The `CoreGenerateSatelliteAssemblies` task first calls the `WriteCodeFragment` task to write a bunch of attributes to a .cs file, and then calls the `Csc` task to compile it (along with the .resource files, of course). However, the call to `WriteCodeFragment` will use the project's language to generate the source file. This means that in a VB project we'll end up generating VB code into a .cs file which we then try to compile with csc.exe. That doesn't end well. The fix here is to always pass "C#" as the language to `WriteCodeFragment`.
nguerrera
approved these changes
Nov 16, 2017
JL03-Yue
pushed a commit
that referenced
this pull request
Mar 19, 2024
…239-8eed-59f1d912a72e [release/6.x] Update dependencies from dotnet/roslyn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1748.
The
CoreGenerateSatelliteAssembliestask first calls theWriteCodeFragmenttask to write a bunch of attributes to a .cs file,and then calls the
Csctask to compile it (along with the .resourcefiles, of course).
However, the call to
WriteCodeFragmentwill use the project's languageto generate the source file. This means that in a VB project we'll end
up generating VB code into a .cs file which we then try to compile with
csc.exe. That doesn't end well.
The fix here is to always pass "C#" as the language to
WriteCodeFragment.