Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-#1521 Output the file path in warning message #1530

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Fix-#1521 Output the file path in warning message #1530

merged 2 commits into from
Oct 30, 2017

Conversation

tishion
Copy link

@tishion tishion commented Aug 23, 2017

This PR only enriches the log message with the file path which caused the warning, but it doesn't provide the approach to allow the user to ignore these kind of warnings. Please refer to the issue #1521

@tishion tishion changed the title Output the file path. Fix-#1521 Output the file path in warning message Aug 23, 2017
@ericstj
Copy link
Member

ericstj commented Aug 23, 2017

Change LGTM. /cc @dsplaisted for review.

@wli3
Copy link

wli3 commented Aug 24, 2017

@tishion thank you! did you edit xlf files by hand? You should run ./build.cmd /p:UpdateXlfOnBuild=true to update them after you edit resx to update by build process

@tishion
Copy link
Author

tishion commented Aug 24, 2017

@wli3 Updated it by the msbuild, but i found it will not extract the parameter list, so i updated the translated result by adding the parameter list(keep the needs-review-translation status).

@wli3
Copy link

wli3 commented Aug 24, 2017

@nguerrera do you know how loc team handles the parameter list?

<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
 -        <target state="translated">Die aufgelöste Datei enthält ein fehlerhaftes Image oder keine Metadaten, oder der Zugriff ist aus anderen Gründen nicht möglich. {0}</target>
 +        <source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
 +        <target state="needs-review-translation">Die aufgelöste Datei enthält ein fehlerhaftes Image oder keine Metadaten, oder der Zugriff ist aus anderen Gründen nicht möglich. {0} {1}</target>
          <note />

will they add the {1} for us?

@ericstj
Copy link
Member

ericstj commented Sep 8, 2017

Test Ubuntu14.04 Debug

@nguerrera
Copy link
Contributor

@wli3 Yes, they will update the placeholders to match. (One subtlety is that it is only safe to add placeholders, not remove them, because if string.Format call passes fewer args than old translation, it will fail until loc catches up.) This change is OK.

@nguerrera nguerrera merged commit f5cda4d into dotnet:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants