Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-#1521 Output the file path in warning message #1530

Merged
merged 2 commits into from
Oct 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if "%ERRORLEVEL%" == "0" (
set DeveloperCommandPrompt=%VS150COMNTOOLS%\VsDevCmd.bat

if not exist "%DeveloperCommandPrompt%" (
echo In order to build this repository, you either need 'msbuild' on the path or Visual Studio 2015 installed.
echo In order to build this repository, you either need 'msbuild' on the path or Visual Studio 2017 installed.
echo.
echo Visit this page to download:
echo.
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/Common/Resources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
<value>'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</value>
</data>
<data name="GetDependsOnNETStandardFailedWithException" xml:space="preserve">
<value>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</value>
<value>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</value>
</data>
<data name="UnsupportedSDKVersionForNetStandard20" xml:space="preserve">
<value>The version of Microsoft.NET.Sdk used by this project is insufficient to support .NET Standard 2.0 which is required by this project's references. Please install version 2.0 or higher of the .NET Core SDK.</value>
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Přeložený soubor má nesprávnou image, nemá žádná metadata nebo je jiným způsobem nedostupný. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Přeložený soubor má nesprávnou image, nemá žádná metadata nebo je jiným způsobem nedostupný. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Die aufgelöste Datei enthält ein fehlerhaftes Image oder keine Metadaten, oder der Zugriff ist aus anderen Gründen nicht möglich. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Die aufgelöste Datei enthält ein fehlerhaftes Image oder keine Metadaten, oder der Zugriff ist aus anderen Gründen nicht möglich. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">El archivo resuelto tiene una imagen incorrecta, no tiene metadatos o no es posible su acceso. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">El archivo resuelto tiene una imagen incorrecta, no tiene metadatos o no es posible su acceso. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Le fichier résolu a une image incorrecte, ne comporte pas de métadonnées ou n'est pas accessible. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Le fichier résolu a une image incorrecte, ne comporte pas de métadonnées ou n'est pas accessible. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Il file risolto contiene un'immagine danneggiata, non contiene metadati o è inaccessibile per altri motivi. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Il file risolto contiene un'immagine danneggiata, non contiene metadati o è inaccessibile per altri motivi. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">解決されたファイルには、無効なイメージが含まれているか、メタデータが存在しないか、またはアクセスできません。{0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">解決されたファイルには、無効なイメージが含まれているか、メタデータが存在しないか、またはアクセスできません。{0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">확인된 파일의 이미지가 잘못되었거나, 메타데이터가 없거나, 파일 자체에 액세스할 수 없습니다. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">확인된 파일의 이미지가 잘못되었거나, 메타데이터가 없거나, 파일 자체에 액세스할 수 없습니다. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Rozpoznany plik ma zły obraz, nie ma metadanych lub jest w inny sposób niedostępny. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Rozpoznany plik ma zły obraz, nie ma metadanych lub jest w inny sposób niedostępny. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">O arquivo resolvido tem uma imagem inválida, não tem metadados ou está inacessível. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">O arquivo resolvido tem uma imagem inválida, não tem metadados ou está inacessível. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Найденный файл имеет неправильный образ, не имеет метаданных или недоступен по другим причинам. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Найденный файл имеет неправильный образ, не имеет метаданных или недоступен по другим причинам. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">Çözümlenen dosyada hatalı görüntü var, meta veri yok veya dosya erişilemez durumda. {0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">Çözümlenen dosyada hatalı görüntü var, meta veri yok veya dosya erişilemez durumda. {0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">解析的文件包含错误图像、无元数据或不可访问。{0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">解析的文件包含错误图像、无元数据或不可访问。{0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@
<note />
</trans-unit>
<trans-unit id="GetDependsOnNETStandardFailedWithException">
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0}</source>
<target state="translated">解析的檔案含有毀損的映像、沒有中繼資料,或是無法存取。{0}</target>
<source>Resolved file has a bad image, no metadata, or is otherwise inaccessible. {0} {1}</source>
<target state="needs-review-translation">解析的檔案含有毀損的映像、沒有中繼資料,或是無法存取。{0} {1}</target>
<note />
</trans-unit>
<trans-unit id="UnsupportedSDKVersionForNetStandard20">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private bool AnyReferenceDependsOnNETStandard()
catch (Exception e) when (IsReferenceException(e))
{
// ResolveAssemblyReference treats all of these exceptions as warnings so we'll do the same
Log.LogWarning(Strings.GetDependsOnNETStandardFailedWithException, e.Message);
Log.LogWarning(Strings.GetDependsOnNETStandardFailedWithException, e.Message, referenceSourcePath);
}
}
}
Expand Down