Suppress assets messages for Clean target. #1821
Conversation
peterhuene
force-pushed
the
clean-suppress-asset-messages
branch
from
7cf822b
to
f096c02
Compare
| <PropertyGroup> | ||
| <CoreCleanDependsOn> | ||
| SuppressAssetsLogMessages; | ||
| $(CoreCleanDependsOn); |
There was a problem hiding this comment.
We likely need to turn it back on after Clean because Rebuild is Clean;Rebuild
There was a problem hiding this comment.
Good catch. I'll fix that.
There was a problem hiding this comment.
I wonder if we can use $(BuildingProject) != "true" instead. It is flipped to true before CoreBuild. cc @davkean, @rainersigwald
There was a problem hiding this comment.
Probably not because that will break design-time builds from getting the diagnostics (I think).
peterhuene
force-pushed
the
clean-suppress-asset-messages
branch
2 times, most recently
from
65c0b74
to
0d7dc1e
Compare
|
@nguerrera I've pushed up the fix to the rebuild target so that it continues to log assets messages. We can't currently use I'm completely open to a better way of accomplishing this than what I have here; this feels kludgy. |
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
@dsplaisted @tannergooding do we really need the test projects in the SDK repo to be as explicit as it is below?
|
ping @dotnet/dotnet-cli to get a code review here. |
| @@ -108,10 +108,14 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Common", "Common", "{529365 | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.NET.Build.Tests", "src\Tests\Microsoft.NET.Build.Tests\Microsoft.NET.Build.Tests.csproj", "{52CB4546-DD2D-4207-B6E1-494C9506D1C1}" | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.NET.Clean.Tests", "src\Tests\Microsoft.NET.Clean.Tests\Microsoft.NET.Clean.Tests.csproj", "{5CBFF0EE-71EA-49CC-8369-34A9A62C8116}" | |||
There was a problem hiding this comment.
I'm not sure we need the overhead of two more test projects for these. I'd be fine cheating and putting them in the build.tests project.
There was a problem hiding this comment.
(I don't have a strong opinion on this I requested changes based on another part that I misunderstood.)
This commit adds macOS `.DS_Store` files to .gitignore.
This commit ensures that messages from `project.assets.json` aren't logged for the `Clean` target. If a project is cleaned that has diagnostic messages stored from a previous restore operation, the Clean target would previously log the messages via the `ReportAssetsLogMessages` target. Since a clean operation does not perform a restore, this is confusing to users. The fix is to set the `EmitAssetsLogMessages` property to `false` for the `Clean` target, but not the `Rebuild` target that depends on the `Clean` target. Fixes dotnet/cli#8027.
peterhuene
force-pushed
the
clean-suppress-asset-messages
branch
from
0d7dc1e
to
7e7d8dc
Compare
Enable source-build prebuilt detection
This commit ensures that messages from
project.assets.jsonaren't logged forthe
Cleantarget. If a project is cleaned that has diagnostic messagesstored from a previous restore operation, the Clean target would previously
log the messages via the
ReportAssetsLogMessagestarget.Since a clean operation does not perform a restore, this is confusing to users.
The fix is to set the
EmitAssetsLogMessagesproperty tofalsefor theCleantarget.Fixes dotnet/cli#8027.