Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress assets messages for Clean target. #1821

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Suppress assets messages for Clean target. #1821

merged 2 commits into from
Feb 6, 2018

Commits on Feb 6, 2018

  1. Ignore macOS .DS_Store files. 

    This commit adds macOS `.DS_Store` files to .gitignore.
    Peter Huene committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    c199f6e View commit details
    Browse the repository at this point in the history

  2. Suppress assets messages for Clean target. 

    This commit ensures that messages from `project.assets.json` aren't logged for
the `Clean` target.  If a project is cleaned that has diagnostic messages
stored from a previous restore operation, the Clean target would previously
log the messages via the `ReportAssetsLogMessages` target.

Since a clean operation does not perform a restore, this is confusing to users.
The fix is to set the `EmitAssetsLogMessages` property to `false` for the
`Clean` target, but not the `Rebuild` target that depends on the `Clean`
target.

Fixes dotnet/cli#8027.
    Peter Huene committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    7e7d8dc View commit details
    Browse the repository at this point in the history