Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netsdk overrides #2021

Closed

Conversation

KevinRansom
Copy link
Member

Due to the way F# is integrated into the Net Sdk it is not possible for an F# target file to override SDK targets.

We need to be able to do that to enable the Net Sdkmechanism to add AssemblyInfo properties to F# apps and libraries.

This PR renames the existing Microsoft.Net.Sdk.FSharp.targets to Microsoft.FSharp.NetSdk.targets, so that we can use the name Microsoft.Net.Sdk.FSharp.targets consistently with C# and VB.

Microsoft.Net.Sdk.FSharp.targets selects a target file deployed with F# compiler.

@nguerrera, @livarcocc , @brettfo

livarcocc and others added 30 commits May 24, 2017 00:21
Update the branding in master to preview3.
LOC CHECKIN | sdk-master | 20170529
Conflicts:
	TestAssets/TestProjects/LinkTest/LinkTest/LinkTest.csproj
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.cs.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.de.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.es.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.fr.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.it.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.ja.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.ko.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.pl.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.pt-BR.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.ru.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.tr.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.zh-Hans.xlf
	src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.zh-Hant.xlf
MSBuild first does a default InvokeMember using the Type.DefaultMember then falls back to an ordinal ignore case match if that fails. This avoids that second lookup by picking the correct case of "SubString". Hit while debugging: dotnet/msbuild#2217.
Avoid first chance exception opening SDK projects
The old implementation combined the relative `<ProjectReference Include="..." />` path with the directory of the `ProjectAssetFile`.
Corrected this to combine the relative project reference with the current's project path.
This was allocating 0.2% of all memory during some design-time builds.
Insert NuGet Build 4.4.0-preview1-4365 and corresponding CLI version into sdk
Change xml formatting for store artifacts xml
This condition was being interpreted as a content, because the $()
expression never closed, so it was comparing the literal string
`$(ImportNuGetBuildTasksPackTargetsFromSdk` to `false`, which doesn't
match.

Fixes dotnet#1491.
tmat and others added 26 commits February 15, 2018 09:35
* Update RepoToolset to 1.0.0-beta-62615-02

Sets algorithm used to calculate source file checksums stored in PDB to SHA256.
…release/2.1.3xx

Merge release/2.1.2xx to release/2.1.3xx
…ctory

Rename SDK build directory to "targets" in source and layout
… of the CLI. Also replaced NETSdkError with NETSdkMessage. This message will be driven by a property set by the CLI.
…etstandard-package

Update implicit NETStandard.Library package version, and re-enable test
do not add reference to Microsoft.NETCore.Platforms during dotnet pack for tools
…so that we can get a good stack trace when it fails with the ArgumentOutOfRangeException.
Displaying a message whenever a build happens using a preview version of the CLI
The input of PackTask is relative path. And it ends up getting wrong full path in the task (prefixed with Library path instead of App path). Give PackTask full path as input.
@KevinRansom KevinRansom changed the base branch from master to release/2.1.2xx March 5, 2018 19:33
@KevinRansom KevinRansom closed this Mar 5, 2018
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
…108.3 (#2021)

[main] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.