Merge pull request #83 from dinomite/parent-reporter

Move start() to AbstractReporter
dropwizard · Sep 26, 2011 · 572ef9f · 572ef9f
2 parents bf6d1d2 + f4dcce9
commit 572ef9f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/metrics-core/src/main/java/com/yammer/metrics/reporting/AbstractReporter.java b/metrics-core/src/main/java/com/yammer/metrics/reporting/AbstractReporter.java
@@ -1,6 +1,7 @@
 package com.yammer.metrics.reporting;
 
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
 
 import com.yammer.metrics.core.MetricsRegistry;
 
@@ -15,4 +16,12 @@ protected AbstractReporter(MetricsRegistry metricsRegistry, String name) {
 
     @Override
     public abstract void run();
+
+    /**
+     * Starts sending output to ganglia server.
+     *
+     * @param period the period between successive displays
+     * @param unit   the time unit of {@code period}
+     */
+    public abstract void start(long period, TimeUnit unit);
 }
diff --git a/metrics-core/src/main/java/com/yammer/metrics/reporting/JmxReporter.java b/metrics-core/src/main/java/com/yammer/metrics/reporting/JmxReporter.java
@@ -304,7 +304,7 @@ public List<?> values() {
     private static JmxReporter INSTANCE;
     public static final void startDefault(MetricsRegistry defaultMetricsRegistry) {
         INSTANCE = new JmxReporter(defaultMetricsRegistry);
-        INSTANCE.start();
+        INSTANCE.start(1, TimeUnit.MINUTES);
     }
 
     public JmxReporter(MetricsRegistry metricsRegistry) {
@@ -313,8 +313,8 @@ public JmxReporter(MetricsRegistry metricsRegistry) {
         this.server = ManagementFactory.getPlatformMBeanServer();
     }
 
-    public void start() {
-        tickThread.scheduleAtFixedRate(this, 0, 1, TimeUnit.MINUTES);
+    public void start(long period, TimeUnit unit) {
+        tickThread.scheduleAtFixedRate(this, 0, period, unit);
         // then schedule the tick thread every 100ms for the next second so
         // as to pick up the initialization of most metrics (in the first 1s of
         // the application lifecycle) w/o incurring a high penalty later on