Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move start() to AbstractReporter #83

Merged
merged 1 commit into from
Sep 26, 2011
Merged

Move start() to AbstractReporter #83

merged 1 commit into from
Sep 26, 2011

Conversation

dinomite
Copy link
Contributor

Moved the start() method to Abstract Reporter and update JmxReporter to match.

This enables injecting a Reporter as a dependency:

public Foo(AbstractReporter reporter) {
    this.reporter = reporter;
    reporter.start(60, TimeUnit.SECONDS);
}

codahale added a commit that referenced this pull request Sep 26, 2011
@codahale
Merge pull request #83 from dinomite/parent-reporter
572ef9f 
Move start() to AbstractReporter
@codahale codahale merged commit 572ef9f into dropwizard:development Sep 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dinomite @analytically @codahale