Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to query individual health checks #898

Closed
wants to merge 1 commit into from

Conversation

osigida
Copy link

@osigida osigida commented Dec 14, 2015

New feature: ability to query individual health checks

We have few health checks in our application. and one of them is basic dead-lock threads.
When this happens we have no choice than to restart the app.
We would like to automate it but we don't like to query all health checks and then parse the response, because it is useless to call all of them and bring some logic to the monitoring tool. Instead we would like to query individual check and act immediately if its failing.

@osigida
Copy link
Author

osigida commented Feb 5, 2016

@ryantenney I was trying to hack and manage some tests, but the way how the code is organised it is impossible... havy refactoring for health-check servlet is required.

@ingwarsw
Copy link

Our company also would benefit from such feature..

Any help needed to make it possible?

@osigida
Copy link
Author

osigida commented Apr 11, 2016

@ingwarsw maybe if you can come up with any kind of unit test?
we miserably failed to find any way to unit-test this feature.

@ingwarsw
Copy link

Will try..

Do i read correctly that url for test should be in format heatlh/nameOfHealthCheck ?

@ingwarsw
Copy link

@ryantenney Will it be possible to add it after adding tests and other required stuff or its not desired feature at all?

@osigida
Copy link
Author

osigida commented Apr 11, 2016

@ingwarsw, right
there are 2 ways to query it
/healthcheck to query all registered health checks or
/healthcheck/name_of_healthcheck to query one of them, example: /healthcheck/deadlocks

@ingwarsw
Copy link

Tests was actually easy :)
I refactored it a bit.. but I dont want to create other PR.

Here it is..
https://github.com/dropwizard/metrics/compare/master...ingwarsw:individual-healthchecks?expand=1

@osigida
Copy link
Author

osigida commented Apr 12, 2016

the PR is recreated on top of 3.2-development branch
see #940

@osigida osigida closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants