New feature: ability to query individual health checks #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have few health checks in our application. and one of them is basic dead-lock threads. When this happens we have no choice than to restart the app. We would like to automate it but we don't like to query all health checks and then parse the response, because it is useless to call all of them and bring some logic to the monitoring tool. Instead we would like to query individual check and act immediately if its failing. thanks to @ingwarsw for sorting out unit-tests
| final Map<String, HealthCheck.Result> results; | ||
| String name = getHealthCheckName(req); | ||
| if (name != null) { | ||
| results = Collections.singletonMap(name, registry.runHealthCheck(name)); |
There was a problem hiding this comment.
Actually that method throws NoSuchElementException when check is not found.
You should create method that would check if that check exists and only then call method.
If check is not existing you should return empty map so responses (all/one) would be consistent.
osigida
force-pushed
the
individual-healthchecks-3-2
branch
from
388d8af
to
1b2bb10
Compare
arteam
force-pushed
the
3.2-development
branch
from
915f50d
to
081bb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have few health checks in our application. and one of them is basic dead-lock threads.
When this happens we have no choice than to restart the app.
We would like to automate it but we don't like to query all health checks and then parse the response, because it is useless to call all of them and bring some logic to the monitoring tool. Instead we would like to query individual check and act immediately if its failing.
thanks to @ingwarsw for sorting out unit-tests