Refactor SSHTunnel
#1669
Merged
Refactor SSHTunnel
#1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 4 different `*SSHTunnel` classes with a common `SSHTunnel` class. The class implements both remote-to-local and local-to-remote port forwarding where both TCP and Unix sockets can be used on either end, which will be useful for future features. This commit does not change `dstack` behavior for end users.
un-def
reviewed
Sep 8, 2024
un-def
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 4 different
*SSHTunnelclasses with acommon
SSHTunnelclass. The class implementsboth remote-to-local and local-to-remote port
forwarding where both TCP and Unix sockets can be
used on either end, which will be useful for
#1633 and #1595.
This commit does not change
dstackbehavior forend users.