Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Android UA check #494

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

jonathanKingston
Copy link
Collaborator

Reviewer: @GioSensation
Asana:

Description

Remove the UA check as it's no longer valid or used.

Steps to test

Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Was left there just in case, I think, but yeah useless.

@jonathanKingston jonathanKingston merged commit 7ce06a8 into main Feb 8, 2024
1 check passed
@jonathanKingston jonathanKingston deleted the jkt/removeAndroidUACheck branch February 8, 2024 08:32
CDRussell pushed a commit to duckduckgo/Android that referenced this pull request Mar 18, 2024
Task/Issue URL:
https://app.asana.com/0/1206839421155384/1206839421155384
Autofill Release:
https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0


## Description
Updates Autofill to version
[10.2.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0).

### Autofill 10.2.0 release notes
## What's Changed
* Remove unused Android UA check by @jonathanKingston in
duckduckgo/duckduckgo-autofill#494
* fix tracker radar kit reference by @brindy in
duckduckgo/duckduckgo-autofill#505
* Update password-related json files (2024-03-04) by @daxmobile in
duckduckgo/duckduckgo-autofill#518
* separate 'third party provider' feature by @shakyShane in
duckduckgo/duckduckgo-autofill#252
* marking flaky tests by @shakyShane in
duckduckgo/duckduckgo-autofill#524
* remove device-specifc 'isEnabled' checks by @shakyShane in
duckduckgo/duckduckgo-autofill#523
* fixing some flaky tests by @shakyShane in
duckduckgo/duckduckgo-autofill#526
* Fixes bugs for Lufthansa, Twitter, Rumble by @GioSensation in
duckduckgo/duckduckgo-autofill#529
* Update Github action dependency by @GioSensation in
duckduckgo/duckduckgo-autofill#531

## New Contributors
* @brindy made their first contribution in
duckduckgo/duckduckgo-autofill#505

**Full Changelog**:
duckduckgo/duckduckgo-autofill@10.1.0...10.2.0

## Steps to test
This release has been tested during autofill development. For smoke test
steps see [this
task](https://app.asana.com/0/1198964220583541/1200583647142330/f).

Co-authored-by: GioSensation <1828326+GioSensation@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants