remove device-specifc 'isEnabled' checks #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
shakyShane
force-pushed
the
03-07-remove_device-specifc_isEnabled_checks
branch
from
20899b0
to
3d7f66a
Compare
This was referenced Mar 7, 2024
Merged
Draft
shakyShane
force-pushed
the
03-07-remove_device-specifc_isEnabled_checks
branch
from
3d7f66a
to
7207a7b
Compare
added 2 commits
March 7, 2024 14:46
GioSensation
approved these changes
Mar 7, 2024
This was referenced Mar 14, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Mar 18, 2024
Task/Issue URL: https://app.asana.com/0/1206839421155384/1206839421155384 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0 ## Description Updates Autofill to version [10.2.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.2.0). ### Autofill 10.2.0 release notes ## What's Changed * Remove unused Android UA check by @jonathanKingston in duckduckgo/duckduckgo-autofill#494 * fix tracker radar kit reference by @brindy in duckduckgo/duckduckgo-autofill#505 * Update password-related json files (2024-03-04) by @daxmobile in duckduckgo/duckduckgo-autofill#518 * separate 'third party provider' feature by @shakyShane in duckduckgo/duckduckgo-autofill#252 * marking flaky tests by @shakyShane in duckduckgo/duckduckgo-autofill#524 * remove device-specifc 'isEnabled' checks by @shakyShane in duckduckgo/duckduckgo-autofill#523 * fixing some flaky tests by @shakyShane in duckduckgo/duckduckgo-autofill#526 * Fixes bugs for Lufthansa, Twitter, Rumble by @GioSensation in duckduckgo/duckduckgo-autofill#529 * Update Github action dependency by @GioSensation in duckduckgo/duckduckgo-autofill#531 ## New Contributors * @brindy made their first contribution in duckduckgo/duckduckgo-autofill#505 **Full Changelog**: duckduckgo/duckduckgo-autofill@10.1.0...10.2.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <1828326+GioSensation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana:
Description
All platforms provide
RuntimeConfigurationnow - either async or via global config variable replacements, so we should remove all device-specific implementations and defer only todevice.settings.enabled. This gives a single place check/debug.Now the mental model matches on every platform:
Settings.enabledis then derived from itdevice.settings.enabledis the single go-to source of truthThe only original call I left in place, is within the very first first stage of initialization, as that acts as a nice early return when possible
Steps to test