Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old versions of Node.js from .travis.yml + Update Deps #237

Closed
nelsonic opened this issue Jun 14, 2021 · 1 comment · Fixed by #238
Closed

Remove old versions of Node.js from .travis.yml + Update Deps #237

nelsonic opened this issue Jun 14, 2021 · 1 comment · Fixed by #238
Assignees
@nelsonic
Labels
chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

We have a couple of ancient versions of node.js in the .travis.yml file:

aws-sdk-mock/.travis.yml

Lines 2 to 7 in f78025f

node_js:
- "node"
- "8"
- "10"
- "12"
- "14"

Also, we have "node" which is just the "current" version, i.e. not very explicit.
It caused a break in a recent PR build: #236 (comment)

Going to remove the older versions and the non-specific one.
@nelsonic nelsonic added the chore a tedious but necessary task often paying technical debt label Jun 14, 2021
@nelsonic nelsonic self-assigned this Jun 14, 2021
@nelsonic nelsonic added the T25m Time Estimate 25 Minutes label Jun 14, 2021
@nelsonic
Copy link
Member Author

At the time of writing v12 and v14 are the supported LTS versions of Node: https://nodejs.org/en/about/releases
image

So I'm removing the others as they are no longer supported. ✂️

nelsonic added a commit that referenced this issue Jun 14, 2021
@nelsonic
remove old (no longer supported) versions of node.js from .travis.yml…
46cd858 
… file; fixes #237
@nelsonic nelsonic mentioned this issue Jun 14, 2021
Merged
1 task
@nelsonic nelsonic changed the title Remove old versions of Node.js from .travis.yml Remove old versions of Node.js from .travis.yml + Update Deps Jun 14, 2021
nelsonic added a commit that referenced this issue Jun 14, 2021
@nelsonic
update version of Sinon from v9 to v11 #237
bfdf8db
nelsonic added a commit that referenced this issue Jun 14, 2021
@nelsonic
update aws-sdk dependency from 2.710 to 2.928 #237
9d34e6f
nelsonic added a commit that referenced this issue Jun 14, 2021
@nelsonic
Add support for streaming S3 Objects #236 & update sinon+aws-sdk #237
5f4a1f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove old (no longer supported) versions of node.js from .travis.yml dwyl/aws-sdk-mock
1 participant
@nelsonic