Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old (no longer supported) versions of node.js from .travis.yml #238

Merged
merged 4 commits into from
Jun 14, 2021
Merged

remove old (no longer supported) versions of node.js from .travis.yml #238

merged 4 commits into from
Jun 14, 2021

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Jun 14, 2021
@nelsonic nelsonic self-assigned this Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #238 (5f4a1f0) into master (f78025f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          118       118           
=========================================
  Hits           118       118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78025f...5f4a1f0. Read the comment docs.

@nelsonic
Copy link
Member Author

Build passes again. Going to attempt to update dependencies ... ⏳

@nelsonic
Copy link
Member Author

This is as far as I'm going to take updates tonight. tap removed the done() in v15 so that will require a bit more work ...
just going to bump the version and publish to NPM.

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jun 14, 2021
@nelsonic nelsonic requested a review from iteles June 14, 2021 21:00
@nelsonic nelsonic assigned iteles and unassigned nelsonic Jun 14, 2021
@nelsonic
Copy link
Member Author

@iteles please review & merge when you can. Thanks. 🌻

iteles
iteles approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @nelsonic

@iteles iteles merged commit 509c935 into master Jun 14, 2021
@iteles iteles deleted the remove-old-versions-of-nodejs-issue-#237 branch June 14, 2021 21:22
@abetomo abetomo mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old versions of Node.js from .travis.yml + Update Deps
2 participants
@nelsonic @iteles