Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21605] Use @FINAL for ROS2 types by default #394

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[21605] Use @FINAL for ROS2 types by default #394

merged 1 commit into from
Sep 10, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 9, 2024 •
edited
Loading

Description

Use FINAL extensibility for ROS2 types by default.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Use @FINAL for ROS2 types by default [21605] Use @FINAL for ROS2 types by default Sep 9, 2024
@MiguelCompany MiguelCompany added this to the v4.0.1 milestone Sep 9, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 9, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Sep 10, 2024
@richiware
Refs #21577. Use @Final for ROS2 types by default
08d93cc 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany September 10, 2024 07:13
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 10, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 10, 2024
@richiware richiware merged commit 9f6854e into master Sep 10, 2024
4 checks passed
@richiware richiware deleted the feature/21577 branch September 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany