Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21604] Remove function can lead to error #157

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[21604] Remove function can lead to error #157

merged 1 commit into from
Sep 10, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 9, 2024 •
edited by MiguelCompany
Loading

Description

This PR removes a function which wouldn't exists because it doesn't follow the mechanism to calculate extensibility.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.

@richiware
Refs #21577. Remove function can be misleading
fded1bf 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Remove function can lead to error [21604] Remove function can lead to error Sep 9, 2024
@MiguelCompany MiguelCompany added this to the v4.0.1 milestone Sep 10, 2024
@richiware richiware mentioned this pull request Sep 10, 2024
Merged
6 tasks
@richiware richiware merged commit 015e2f1 into master Sep 10, 2024
2 checks passed
@richiware richiware deleted the feature/21577 branch September 10, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany