Update my_robot_rviz.launch #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eborghi10
requested changes
Jun 29, 2021
| @@ -8,6 +8,9 @@ | |||
|
|
|||
| <arg name="rvizconfig" | |||
| default="$(find my_robot_description)/rviz/my_robot.rviz" /> | |||
|
|
|||
| <!-- Ktysai necessary to solve NO GUI for joint_state_publisher when using RVIZ --> | |||
There was a problem hiding this comment.
No need to add your username in the comments you made. Please remove them.
| unless="$(arg use_gui)" /> <!-- Ktysai last two lines necessary to solve NO GUI for joint_state_publisher when using RVIZ --> | ||
| <!-- Ktysai node necessary to solve NO GUI for joint_state_publisher when using RVIZ --> | ||
| <node name="joint_state_publisher_gui" | ||
| pkg="joint_state_publisher_gui" |
There was a problem hiding this comment.
Please add in the package.xml file joint_state_publisher_gui as run_depend.
There was a problem hiding this comment.
Is I do like that is no need to mention use_gui here?
Comment on lines
50
to
54
| <!-- KTYSAI | ||
| put type="robot_state_publisher", in order to make the robot aprear corectly in RVIz and deal with this type of error message: | ||
| "ERROR: cannot launch node of type [robot_state_publisher/state_publisher]: Cannot locate node of type [state_publisher] in package [robot_state_publisher]. | ||
| Make sure file exists in package path and permission is set to executable (chmod +x)" | ||
| --> |
There was a problem hiding this comment.
No need this comment here, state_publisher is an old name that was changed a long time ago.
There was a problem hiding this comment.
in the launch file it was like that, unfortunately.
eborghi10
requested changes
Jun 29, 2021
Co-authored-by: Emiliano Borghi <emiliano.borghi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS NOETIC
Solution for:
#1
in order to make the robot aprear corectly in RVIz and deal with this type of error message:
"ERROR: cannot launch node of type [robot_state_publisher/state_publisher]: Cannot locate node of type [state_publisher] in package [robot_state_publisher]. Make sure file exists in package path and permission is set to executable (chmod +x)"
#2
necessary to solve NO GUI for joint_state_publisher when using RVIZ