Fix search debounce in search-in-workspace widget #9579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Bodeen <gabriel.bodeen@ericsson.com>
vince-fugnitto
added
the
search in workspace
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
vince-fugnitto
approved these changes
Jun 21, 2021
dna2github
pushed a commit
to dna2fork/theia
that referenced
this pull request
Aug 25, 2021
* Fix search debounce in search-in-workspace widget Signed-off-by: Gabriel Bodeen <gabriel.bodeen@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Bodeen gabriel.bodeen@ericsson.com
What it does
The
searchmethod ofSearchInWorkspaceWidgetreferences a debounce period but actually searches on every keyup with a delay. This PR adds aclearTimeoutto debounce as intended.How to test
The diff is very simple, but one way to confirm via testing is to add a logging statement to the setTimeout callback. Then you can observe the logs occurring on every keyup on
masterbut debounced on this branch.Review checklist
Reminder for reviewers