Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search debounce in search-in-workspace widget #9579

Merged
merged 2 commits into from
Jun 30, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
force browser type for setTimeout
  • Loading branch information
gbodeen committed Jun 14, 2021
commit c7927834ba4eb13b8af4fb9f57333877a7690e42
Original file line number Diff line number Diff line change
Expand Up @@ -383,14 +383,14 @@ export class SearchInWorkspaceWidget extends BaseWidget implements StatefulWidge
this.doBlurSearchFieldContainer();
}

private _searchTimeout: NodeJS.Timeout;
private _searchTimeout: number;
protected readonly search = (e: React.KeyboardEvent) => {
e.persist();
const searchOnType = this.searchInWorkspacePreferences['search.searchOnType'];
if (searchOnType) {
const delay = this.searchInWorkspacePreferences['search.searchOnTypeDebouncePeriod'] || 0;
clearTimeout(this._searchTimeout);
this._searchTimeout = setTimeout(() => this.doSearch(e), delay);
window.clearTimeout(this._searchTimeout);
this._searchTimeout = window.setTimeout(() => this.doSearch(e), delay);
}
};

Expand Down