Update reference to go-mod-core-contracts to fix race condition #2313
Conversation
Signed-off-by: Brandon Forster <me@brandonforster.com>
|
Kudos, SonarCloud Quality Gate passed!
|
michaelestrin
requested review from
AnthonyMBonafide
and removed request for
michaelestrin
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
=======================================
Coverage 37.14% 37.14%
=======================================
Files 158 158
Lines 12824 12824
=======================================
Hits 4764 4764
Misses 7802 7802
Partials 258 258Continue to review full report at Codecov.
|
| @@ -7,7 +7,7 @@ require ( | |||
| github.com/cloudflare/gokey v0.1.0 | |||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible | |||
| github.com/edgexfoundry/go-mod-bootstrap v0.0.11 | |||
| github.com/edgexfoundry/go-mod-core-contracts v0.1.37 | |||
| github.com/edgexfoundry/go-mod-core-contracts v0.1.41 | |||
There was a problem hiding this comment.
Now that all of the other changes are in go-mod-core-contracts should we update to v0.1.42?
There was a problem hiding this comment.
I think there's additional refactoring work in-flight related to this issue (edgexfoundry/go-mod-core-contracts#196) to consolidate common code into the underlying client implementation. Once that's complete, there's an additional follow-on issue (edgexfoundry/go-mod-core-contracts#204) that should be worked before actually updating edgex-go to the latest (that would include those outstanding changes).
|
Closing. It's clear based on conversation that this PR was a little preliminary. A new PR will be created that references this one, addresses #2237, and updates the core contracts version when edgexfoundry/go-mod-core-contracts#204 is merged in and we have a complete codebase on that side. |
Fixes #2237
Signed-off-by: Brandon Forster me@brandonforster.com