Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client endpoints and fix race condition #196

Closed
brandonforster opened this issue Jan 8, 2020 · 0 comments · Fixed by #205
Closed

Refactor client endpoints and fix race condition #196

brandonforster opened this issue Jan 8, 2020 · 0 comments · Fixed by #205
Assignees
@brandonforster
Labels
bug Something isn't working

Comments

@brandonforster
Copy link
Contributor

While working edgexfoundry/edgex-go#2237 it was discovered that the race condition causing the URL to be empty exists for every endpoint on every client. Most have timing such that it won't manifest, but the underlying race condition must be addressed.
@brandonforster brandonforster added the bug Something isn't working label Jan 8, 2020
@brandonforster brandonforster self-assigned this Jan 8, 2020
@brandonforster brandonforster mentioned this issue Jan 8, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 9, 2020
@brandonforster
edgexfoundry#196: Refactor metadata clients.
d0c3967 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
@brandonforster brandonforster mentioned this issue Jan 9, 2020
Merged
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 14, 2020
@brandonforster
edgexfoundry#196: Refactor metadata clients.
63fcee7 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 15, 2020
@brandonforster
edgexfoundry#196: Refactor metadata clients.
5aa1de2 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 16, 2020
@brandonforster
edgexfoundry#196: Follow on from edgexfoundry#195.
ebe72d7 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 16, 2020
@brandonforster
edgexfoundry#196: Applied pattern to core-data clients.
4b3288d 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 16, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 20, 2020
@brandonforster
edgexfoundry#196: Updated with PR feedback.
ea0bf61 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 20, 2020
@brandonforster
edgexfoundry#196: Updated command client with URLClient
b9ec2fb 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 20, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 20, 2020
@brandonforster
edgexfoundry#196: Add URLClient to general client.
15cd04f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 20, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 20, 2020
@brandonforster
edgexfoundry#196: Applied URLClient pattern to notification.
35cccae 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 20, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 20, 2020
@brandonforster
edgexfoundry#196: Applied URLClient pattern to scheduler.
3423255 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 20, 2020
Merged
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
436a34f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@michaelestrin michaelestrin mentioned this issue Jan 21, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
43bb0de 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Updated command client with URLClient
d38330e 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: url->urlPrefix
b9178db 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Add URLClient to general client.
79800dc 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: url->urlPrefix
17a7138 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Applied URLClient pattern to notification.
19cdcb0 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: url->urlPrefix
69f0ac3 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Applied URLClient pattern to scheduler.
6d3824e 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: url->urlPrefix
ce2bd82 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
c77d15f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 21, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
5cd5ab3 
Signed-off-by: Brandon Forster <me@brandonforster.com>
This was referenced Jan 21, 2020
Merged
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 23, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
4f346d3 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 23, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
72f0b52 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@michaelestrin michaelestrin mentioned this issue Jan 23, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 23, 2020
@brandonforster
edgexfoundry#196: Centralized URLClient logic to the request package.
d48a9b4 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Jan 23, 2020
Merged
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 24, 2020
@brandonforster
edgexfoundry#196: Centralized URLClient logic to the request package.
4b1aba3 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 24, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
ee722cc 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 24, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
9f39b3d 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 24, 2020
@brandonforster
edgexfoundry#196: Added more test cases. These are implementation spe…
65bf80c 
…cific and are suspect.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 27, 2020
@brandonforster
edgexfoundry#196: Reduced code duplication and hacky garbage.
f718b51 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 27, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
bb563c6 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 27, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
25d993d 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 27, 2020
@brandonforster
edgexfoundry#196: Interval and Interval Action now have 100% coverage.
94fc3f0 
Signed-off-by: Brandon Forster <me@brandonforster.com>
michaelestrin pushed a commit that referenced this issue Jan 28, 2020
@brandonforster @michaelestrin
Centralize URLClient logic to the Request package (#205)
e252808 
* #196: Centralized URLClient logic to the request package.
* #196: Reduced code duplication and hacky garbage.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: Added unmarshaler interface. Added two basic implem…
3108fcc 
…entations and used those in Interval.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: Added unmarshaler to IntervalAction
95284b5 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: 100% coverage on requestIntervalAction.
15e4b46 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: Added unit tests for interval client.
59fa974 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: Interval action tests.
3e814f2 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 29, 2020
@brandonforster
edgexfoundry#196: Interval and Interval Action now have 100% coverage.
8bd808f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Jan 30, 2020
@brandonforster
edgexfoundry#196: Explicitly ignored unused values.
c3a892f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit that referenced this issue Jan 30, 2020
@brandonforster
Add tests for interval and interval action clients
c0b0a27 
* #196: Added unit tests for interval and interval action clients.

Signed-off-by: Brandon Forster <me@brandonforster.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonforster brandonforster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Centralize URLClient logic to the Request package brandonforster/go-mod-core-contracts
1 participant
@brandonforster