-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add -d/--dev common command-line flag to put service in Dev Mode #516
Conversation
Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the `Host` settings pulled from common configuration to be overridden with the value `localhost`. closes edgexfoundry#509 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 58.30% 57.88% -0.43%
==========================================
Files 27 27
Lines 2168 2189 +21
==========================================
+ Hits 1264 1267 +3
- Misses 824 842 +18
Partials 80 80
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ects Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
131c82f
to
fd80cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the
Host
settings pulled from common configuration to be overridden with the valuelocalhost
.closes #509
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)TBD
Testing Instructions
Use in edgex-go, app sdk and device sdk and make appropriate code changes
Build and run core/support services with "-cp -d" options with other services running in docker
Verify service bootstraps properly
Build and run device-simple with "-cp -d" options with other services running in docker
Verify service bootstraps properly
Build and run app-template with "-cp -d" options with other services running in docker
Verify service bootstraps properly
New Dependency Instructions (If applicable)