Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add -d/--dev common command-line flag to put service in Dev Mode #516

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Apr 26, 2023

Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the Host settings pulled from common configuration to be overridden with the value localhost.

closes #509

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Use in edgex-go, app sdk and device sdk and make appropriate code changes
Build and run core/support services with "-cp -d" options with other services running in docker
Verify service bootstraps properly
Build and run device-simple with "-cp -d" options with other services running in docker
Verify service bootstraps properly
Build and run app-template with "-cp -d" options with other services running in docker
Verify service bootstraps properly

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell changed the title feat: Add -d/--dev common command-lin flag to put service in Dev Mode feat: Add -d/--dev common command-line flag to put service in Dev Mode Apr 26, 2023
Dev Mode is used when running service locally with the other services running in Docker (aka hybrid mode). This causes all the `Host` settings pulled from common configuration to be overridden with the value `localhost`.

closes edgexfoundry#509

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #516 (131c82f) into main (de96246) will decrease coverage by 0.43%.
The diff coverage is 28.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   58.30%   57.88%   -0.43%     
==========================================
  Files          27       27              
  Lines        2168     2189      +21     
==========================================
+ Hits         1264     1267       +3     
- Misses        824      842      +18     
  Partials       80       80              
Impacted Files Coverage Δ
bootstrap/config/config.go 31.37% <0.00%> (-0.81%) ⬇️
config/types.go 12.76% <ø> (ø)
bootstrap/flags/flags.go 60.00% <33.33%> (-2.32%) ⬇️
bootstrap/handlers/clients.go 98.90% <100.00%> (+0.01%) ⬆️
bootstrap/handlers/messaging.go 78.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

config/types.go Outdated Show resolved Hide resolved
…ects

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dev command line flag to apply "Host" env overrides when running in hybrid mode
4 participants