Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [WIP] Remove dev override of Service.Host so IP address can be used #541

Merged
merged 1 commit into from
May 10, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 10, 2023

fixes #540

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run Clean EdgeX non-secure stack
Use this branch in Device SDK to build Device Simple
Change Service.Host in Device Simple config file to be IP address of current system
Run Device Simple with -cp -d -o flags
Verity it starts w/o errors
Send GET request to http://localhost:59882/api/v3/device/name/Simple-Device01/Switch
Verify it returns 200 and an event

New Dependency Instructions (If applicable)

fixes edgexfoundry#540

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev flag override of Service.Host keeps Core Command from working with hybrid service
2 participants