Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor usage of Context in entire repo to make it idiomatic #206

Closed
brandonforster opened this issue Jan 24, 2020 · 0 comments · Fixed by #211
Closed

Refactor usage of Context in entire repo to make it idiomatic #206

brandonforster opened this issue Jan 24, 2020 · 0 comments · Fixed by #211
Assignees
@brandonforster

Comments

@brandonforster
Copy link
Contributor

brandonforster commented Jan 24, 2020 •
edited by michaelestrin
Loading

This repo does not use Golang best practices and does not have ctx context.Context as the first method/function parameter when it is used. This should be done throughout the repo.

This will be a breaking change.

Discussion and discovery from @michaelestrin :
https://github.com/edgexfoundry/go-mod-core-contracts/pull/205/files/4b1aba370a2a780425ec0b989b3dc7884f6a1289#diff-5b56cccfe7a55a3fe3b288bdb434df3e

Related: #205
@brandonforster brandonforster self-assigned this Jan 24, 2020
@brandonforster brandonforster mentioned this issue Jan 30, 2020
Closed
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 1, 2020
@brandonforster
edgexfoundry#206: Refactored so context is the first parameter in eve…
28e9f23 
…ry client it's used in.

Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster brandonforster mentioned this issue Feb 3, 2020
Merged
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 4, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
9d6eebe 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 7, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
99ed888 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 7, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
be5483a 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 10, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
d9d0ac1 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 10, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
9f44489 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 10, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
411ab26 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster added a commit to brandonforster/go-mod-core-contracts that referenced this issue Feb 10, 2020
@brandonforster
edgexfoundry#204: Added structure so that a RegistryClient can use di…
3854ea7 
…fferent algorithms for retrieving a URL.

edgexfoundry#206: Refactor usage of Context to make idiomatic.

edgexfoundry#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
michaelestrin pushed a commit that referenced this issue Feb 10, 2020
@brandonforster
#204: Added structure so that a RegistryClient can use different algo…
b139196 
…rithms for retrieving a URL. (#211)

#206: Refactor usage of Context to make idiomatic.

#209: Remove Endpointer structure.

Signed-off-by: Brandon Forster <me@brandonforster.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonforster brandonforster

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brandonforster