Centralize URLClient logic to the Request package #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
+ Coverage 45.85% 49.3% +3.45%
=========================================
Files 64 64
Lines 2133 1937 -196
=========================================
- Hits 978 955 -23
+ Misses 1066 910 -156
+ Partials 89 72 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Rebase off master to facilitate review/merge and re-request review from me.
Alternately, wait for dependent #203 to be accepted and merged to re-request a review from me.
Signed-off-by: Brandon Forster <me@brandonforster.com>
brandonforster
force-pushed
the
issue_196_centralized
branch
from
d48a9b4
to
4b1aba3
Compare
michaelestrin
suggested changes
Jan 24, 2020
Signed-off-by: Brandon Forster <me@brandonforster.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196.
This is the final PR for #196. This PR moves all calls of
URLPrefixto therequestpackage to reduce duplication.There are two places I would like to call out for special review:
ValueDescriptorsUsage()in metadata/provision_watcher.go andsendLog()in `logger/logger.go.These two functions required me creating a new URLClient that returns an empty string to fulfill the contract and preserve functionality. I did my best, but am not tremendously happy with this solution and would like any suggestions on how to improve it.