-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple component support #116
Add multiple component support #116
Conversation
Overall the proposed solution is ok. Please fix tests and make sure this work in the case of a single component or zero components. |
Currently, components that are either not found in the config or left empty in the fragments are considered unidentified. This is reflected in the changelog with the title and as an With additonal logic, What do you think @endorama? |
I think this should be addressed with a fatal error: if a component is not matched or identified the tool should produce an error and stop processing the consolidated changelog. We can notify users of unmatched and unspecified components in the changelog linter, at this stage we want to output correct release notes that can be reused. |
Discussing how the errors should be handled we noticed there are multiple cases for components configuration based on config and fragment value. Here is the authoritative description of how the tool will manage them (will be updated during the life of this PR).
|
2653a04
to
fa7d3c6
Compare
Closes #63