Add changelog lint cmd #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
lucian-ioan
force-pushed
the
add_changelog_lint_cmd
branch
from
4e98cc2
to
6422a8b
Compare
|
I like the approach, I added a commit that extracts the validators to separate functions, as we need to add tests for them to ensure long term maintainability. Once that is done this will be good to merge. |
endorama
requested changes
Nov 3, 2022
internal/changelog/linter_test.go
Outdated
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestValidators(t *testing.T) { |
There was a problem hiding this comment.
Break this down per validator, as it is now would fail for any validator and that may be confusing to future contributors.
main.go
Outdated
| @@ -25,6 +25,7 @@ func main() { | |||
| rootCmd.AddCommand(cmd.PrHasFragmentCommand(appFs)) | |||
| rootCmd.AddCommand(cmd.RenderCmd(appFs)) | |||
| rootCmd.AddCommand(cmd.VersionCmd()) | |||
| rootCmd.AddCommand(cmd.ChangelogLintCmd(appFs)) | |||
There was a problem hiding this comment.
nit: add this in alphabetical order
endorama
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Cherry-pick of
a7d4406is required. PR #116 should be merged first.