Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display legend extra values when the x scale is ordinal #766

Closed
markov00 opened this issue Jul 28, 2020 · 1 comment · Fixed by #751
Closed

Don't display legend extra values when the x scale is ordinal #766

markov00 opened this issue Jul 28, 2020 · 1 comment · Fixed by #751
Assignees
@markov00
Labels
bug Something isn't working :legend Legend related issue released Issue released publicly :xy Bar/Line/Area chart related

Comments

@markov00
Copy link
Member

Describe the bug
The current extra value displayed on the legend renders by default the last value on the series. This feature is only interesting and useful when rendering charts with a continuous scale along the x. In a categorical scale, the last value doesn't have any special meaning.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/ecstatic-colden-bgzgj?file=/src/App.tsx
  2. The legend is showing the value related to YOW column

Expected behaviour
For ordinal scales along the x axis, the legend extra value should be not displayed until it can be customized to display something else than the last value of the series

Screenshots

Screenshot 2020-07-28 at 13 03 11

Version (please complete the following information):

  • Elastic Charts: all
@markov00 markov00 added bug Something isn't working :legend Legend related issue :xy Bar/Line/Area chart related labels Jul 28, 2020
@markov00 markov00 self-assigned this Jul 28, 2020
@markov00 markov00 mentioned this issue Jul 28, 2020
Merged
3 tasks
markov00 added a commit that referenced this issue Jul 29, 2020
@markov00
feat: streamgraph and fit functions on stacked charts (#751)
268fcc0 
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes:
- fit functions are now available also on stacked charts
- the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis
- Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case
- for zero-based charts (bar and area charts) the fit option doesn't have any effects
- djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering

BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.

fix #766
fix #715
close #450
markov00 pushed a commit that referenced this issue Aug 10, 2020
@semantic-release-bot
chore(release): 21.0.0 [skip ci]
e7a8a30 
# [21.0.0](v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([#763](#763)) ([4455281](4455281))
* **legend:** fix color anchor, add action context, fix action padding ([#774](#774)) ([4590a22](4590a22))
* **tooltip:** placement with left/top legends and single bars ([#771](#771)) ([e576b26](e576b26)), closes [#769](#769) [#770](#770)

### Features

* streamgraph and fit functions on stacked charts ([#751](#751)) ([268fcc0](268fcc0)), closes [#766](#766) [#715](#715) [#450](#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 10, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 21.0.0 [skip ci]
5c68eec 
# [21.0.0](elastic/elastic-charts@v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([opensearch-project#763](elastic/elastic-charts#763)) ([843554f](elastic/elastic-charts@843554f))
* **legend:** fix color anchor, add action context, fix action padding ([opensearch-project#774](elastic/elastic-charts#774)) ([262f8d2](elastic/elastic-charts@262f8d2))
* **tooltip:** placement with left/top legends and single bars ([opensearch-project#771](elastic/elastic-charts#771)) ([75533b1](elastic/elastic-charts@75533b1)), closes [opensearch-project#769](elastic/elastic-charts#769) [opensearch-project#770](elastic/elastic-charts#770)

### Features

* streamgraph and fit functions on stacked charts ([opensearch-project#751](elastic/elastic-charts#751)) ([6f6a8cb](elastic/elastic-charts@6f6a8cb)), closes [opensearch-project#766](elastic/elastic-charts#766) [opensearch-project#715](elastic/elastic-charts#715) [opensearch-project#450](elastic/elastic-charts#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working :legend Legend related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: wiggle and silhouette stacks markov00/elastic-charts
1 participant
@markov00