Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop runtime dependency on base64 #2295

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Earlopain
Copy link
Contributor

#2282 added base64 as a runtime dependency. It's easy enough to replace, the base64 is for the most part a wrapper around the pack/unpack methods.

Also see:

I have made it a dev dependency since test files use it in a bunch of places and replacing all that doesn't make the code much better.

Copy link

cla-checker-service bot commented Feb 5, 2024

💚 CLA has been signed

Copy link

github-actions bot commented Feb 5, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Earlopain

This comment was marked as outdated.

@Earlopain
Copy link
Contributor Author

CI failures seem to be because #2294 isn't merged yet.

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Earlopain, this is great! Yeah, the failures in CI are due to #2294, once I merge that this can be rebased and merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants