Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop base64 gem dependency #51

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

Earlopain
Copy link
Contributor

59d7cab added base64 as a dependency. This instead inlines that call and removes the dependency.

See also:

Types of Changes

  • Maintenance.

Contribution

@ioquatix ioquatix merged commit 46fce42 into socketry:main Feb 7, 2024
14 of 22 checks passed
@Earlopain Earlopain deleted the remove-base64-dep branch February 7, 2024 11:24
@ioquatix
Copy link
Member

ioquatix commented Feb 7, 2024

External tests are failing... need to investigate.

@ioquatix ioquatix added this to the v0.26.1 milestone Feb 7, 2024
@ioquatix
Copy link
Member

ioquatix commented Feb 7, 2024

Are you able to give me your legal name for the copyright?

@Earlopain
Copy link
Contributor Author

Hi @ioquatix, thank you for asking.

I'd prefer not to. I see you already used my username on main, and that's perfectly fine with me. I don't want any connection to a real person through this account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants