-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Handle exposed ref APIs potentially pointing to invalid, off-page, or out of view cells #5572
Merged
cee-chen
merged 10 commits into
elastic:feat/datagrid/5310
from
cee-chen:datagrid/ref/row-index
Feb 1, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2874148
Enable sorting + targeting row indices outside of the current page
cee-chen eaeaba2
Switch data grid example to Typescript
cee-chen 7786fcc
Fix cell expansion buttons on paginated pages not working correctly
cee-chen 4a80624
Attempt to more clearly document `rowIndex`s that are actually `visib…
cee-chen 540de15
[setup] Move imperative handler setup to its own util file
cee-chen 9477d1f
Add catch/check for cell locations that do not exist in the current grid
cee-chen 74a833f
Add getVisibleRowIndex helper
cee-chen ba29a97
Replace grid ref Jest tests with more complete Cypress tests
cee-chen 56465f6
Update documentation with new behavior
cee-chen 55a4ba6
[PR feedback] Rename fns to indicate multiple concerns
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: is there a quick or easy way of making it so this
// @ts-ignore
doesn't show up in our Demo TS tab or CodeSandbox?I'm guessing no unless we switch to a lib with type declarations? (Might be worth doing anyway, what with the whole faker kerfluffle 🤷♀️)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep promising Elizabet that I would make the snapshot of github data we use in the height examples available to other examples, which would hopefully help phase out faker.
Probably not worth putting any time into removing those comments, they may even be beneficial to consumers by indicating what part of an example may need some extra attention when copying.