[EuiInMemoryTable] Fix onTableChange returning the sort field's name instead of field key
#5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Should currently fail with field returns as `Name` instead of `name`
cee-chen
force-pushed
the
in-memory-table/5587
branch
from
f625c78
to
e1cee95
Compare
cee-chen
commented
Feb 1, 2022
Comment on lines
408
to
411
| let sortColumn = findColumnByProp(columns, 'field', sortName as string); | ||
| if (sortColumn == null) { | ||
| sortColumn = findColumnByProp(columns, 'name', sortName as string); | ||
| } |
There was a problem hiding this comment.
I copied this handy 'findColumnBy' logic up above in getInitialSorting:
eui/src/components/basic_table/in_memory_table.tsx
Lines 221 to 226 in e1cee95
There was a problem hiding this comment.
Want to make this a function that's reused both places?
There was a problem hiding this comment.
Ooo, you know it!! 16dc234
thompsongl
approved these changes
Feb 1, 2022
Comment on lines
408
to
411
| let sortColumn = findColumnByProp(columns, 'field', sortName as string); | ||
| if (sortColumn == null) { | ||
| sortColumn = findColumnByProp(columns, 'name', sortName as string); | ||
| } |
There was a problem hiding this comment.
Want to make this a function that's reused both places?
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5588/ |
+ fix value typing to accept names which can be ReactNodes
This reverts commit 3c1e939.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5588/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5588/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5587
TL;DR: On sort, in memory tables'
onTableChangereturn the correctsort.fieldvalue ascolumn.field, but on pagination, it incorrectly returnssort.fieldascolumn.name.Before
Jest test failure comparison:
After
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes