Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiInMemoryTable] Fix onTableChange returning the sort field's name instead of field key #5588

Merged
merged 8 commits into from
Feb 2, 2022
Merged

[EuiInMemoryTable] Fix onTableChange returning the sort field's name instead of field key #5588

merged 8 commits into from
Feb 2, 2022

Commits on Feb 1, 2022

  1. [REVERT] Log onTableChange sort.field output

    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    3c1e939 View commit details
    Browse the repository at this point in the history

  2. Add unit/regression test for buggy behavior 

    - Should currently fail with field returns as `Name` instead of `name`
    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    c8938fa View commit details
    Browse the repository at this point in the history

  3. Fix reportedSortName coming back as name instead of field

    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d155260 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    e1cee95 View commit details
    Browse the repository at this point in the history

  5. [PR feedback] Dry out findColumnByProp logic 

    + fix value typing to accept names which can be ReactNodes
    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    16dc234 View commit details
    Browse the repository at this point in the history

  6. Revert "[REVERT] Log onTableChange sort.field output" 

    This reverts commit 3c1e939.
    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    084b8e4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into in-memory-table/5587

    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    896b118 View commit details
    Browse the repository at this point in the history

  8. changelog

    @cee-chen
    cee-chen committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    f3bc8f6 View commit details
    Browse the repository at this point in the history