Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBasicTable][EuiInMemoryTable][EuiDataGrid] Revert page size number | 'all' type to just number #5699

Merged
merged 12 commits into from
Mar 8, 2022
Merged

[EuiBasicTable][EuiInMemoryTable][EuiDataGrid] Revert page size number | 'all' type to just number #5699

merged 12 commits into from
Mar 8, 2022

Commits on Mar 8, 2022

  1. Revert "Update EuiDataGrid pagination props to accept 'all'" 

    This reverts commit c476dc8.
    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a73a531 View commit details
    Browse the repository at this point in the history

  2. Revert "Update EuiBasicTable and EuiInMemoryTable props to accept 'all'" 

    This reverts commit 8efabe6.
    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b26b454 View commit details
    Browse the repository at this point in the history

  3. Revert "Update documentation examples to use 'all'" 

    This reverts commit 2a05385.
    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    f35c79c View commit details
    Browse the repository at this point in the history

  4. Revert "Update EuiTablePagination to accept number | 'all' instead of… 

    … 0 for all"

This reverts commit 6903978.
    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    cc07948 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    e799c76 View commit details
    Browse the repository at this point in the history

  6. Re-add removed tests/snapshots

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    beb69cb View commit details
    Browse the repository at this point in the history

  7. Re-add datagrid pagination checks

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    aaa5766 View commit details
    Browse the repository at this point in the history

  8. Re-add prop documentation changes

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    03fdeee View commit details
    Browse the repository at this point in the history

  9. Restore pageSize checks that would otherwise result in Infinity

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    c35aa40 View commit details
    Browse the repository at this point in the history

  10. Revert token revert

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    6a0f56a View commit details
    Browse the repository at this point in the history

  11. Update docs (thanks Caroline for the catch)

    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b3807db View commit details
    Browse the repository at this point in the history

  12. [EuiInMemoryTable] Account for pageSizes of 0 

    0 is falsey and thus is failing a bunch of checks/fallthroughs, switching to `??` and `!=` null generally solves the problem
    @cee-chen
    cee-chen committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b8bcfbb View commit details
    Browse the repository at this point in the history