[EuiBasicTable][EuiInMemoryTable][EuiDataGrid] Revert page size number | 'all' type to just number
#5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
table-pagination-all
branch
from
759213a
to
345bc61
Compare
|
Sorry for force push noise, still going through the revert diff and cleaning up various changes we did want in main. Will comment again when done |
cee-chen
force-pushed
the
table-pagination-all
branch
4 times, most recently
from
abc625d
to
85f488f
Compare
cee-chen
force-pushed
the
table-pagination-all
branch
from
85f488f
to
6a0f56a
Compare
0 is falsey and thus is failing a bunch of checks/fallthroughs, switching to `??` and `!=` null generally solves the problem
|
@thompsongl Alrighty, apologies for the noise, this should be all working and the diff looks more sane to me now 🙈 cc @cchaos on this as well, for once the staging link goes up - please feel free to ping if you think the examples are too confusing, particularly the EuiTablePagination one. I actually think the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5699/ |
thompsongl
approved these changes
Mar 8, 2022
cee-chen
added a commit
that referenced
this pull request
Mar 8, 2022
- Missed this just as I was hitting merge on #5699, does not affect any source code
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5699/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5697
Unfortunately the
| 'all'typing (see #5547, particularly the first 4 commits I added) is simply causing too many downstream Typescript shenanigans in Kibana, so in this case typescript should trump API clarity for expedience 😢0representing all instead of-1, does-1feel better?git reverts caused a decent amount of noise and I slightly regret not just working off of mainQA staging
Checklist