Skip to content

Commit

Permalink
[drilldown] fix Darktheme is missing from add drilldowns panel (#147270)
Browse files Browse the repository at this point in the history
Fixes #147147

Replaces #147151. Thanks for the
tip @Dosant

PR passes theme$ to toMountPoint

<img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM"
src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
nreese and kibanamachine authored Jan 10, 2023
1 parent 95a3313 commit 26b2274
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ const actionParams: OpenFlyoutAddDrilldownParams = {
application: {
currentAppId$: new Subject(),
},
theme: {
theme$: new Subject(),
},
} as any,
plugins: {
uiActionsEnhanced,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ export class FlyoutCreateDrilldownAction implements Action<EmbeddableContext> {
placeContext={{ embeddable }}
templates={templates}
onClose={close}
/>
/>,
{ theme$: core.theme.theme$ }
),
{
ownFocus: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ const actionParams: FlyoutEditDrilldownParams = {
application: {
currentAppId$: new Subject(),
},
theme: {
theme$: new Subject(),
},
} as any,
plugins: {
uiActionsEnhanced: uiActions,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ export class FlyoutEditDrilldownAction implements Action<EmbeddableContext> {
placeContext={{ embeddable }}
templates={templates}
onClose={close}
/>
/>,
{ theme$: core.theme.theme$ }
),
{
ownFocus: true,
Expand Down

0 comments on commit 26b2274

Please sign in to comment.