Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drilldown] fix Darktheme is missing from add drilldowns panel #147151

Closed
wants to merge 6 commits into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 6, 2022

Fixes #147147

PR wraps LazyDrilldownManager with KibanaThemeProvider to resolve dark theme issues in drilldown flyout.

Screen Shot 2022-12-06 at 4 54 49 PM

@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0 v8.7.0 Feature:Drilldowns Embeddable panel Drilldowns labels Dec 6, 2022
@nreese
Copy link
Contributor Author

nreese commented Dec 7, 2022

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 7, 2022

@elasticmachine merge upstream

@nreese nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 7, 2022
@nreese nreese marked this pull request as ready for review December 7, 2022 16:04
@nreese nreese requested a review from a team as a code owner December 7, 2022 16:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here toMountPoint supports passing theme$ from core as part of config which is a second argument
Maybe better to use that to avoid another ThemeProvider

toMountPoint(
<plugins.uiActionsEnhanced.DrilldownManager
closeAfterCreate
initialRoute={'/new'}
dynamicActionManager={embeddable.enhancements.dynamicActions}
triggers={triggers}
placeContext={{ embeddable }}
templates={templates}
onClose={close}
/>
),

Same for editFlyout

@nreese
Copy link
Contributor Author

nreese commented Dec 8, 2022

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 8, 2022

Here toMountPoint supports passing theme$ from core as part of config which is a second argument
Maybe better to use that to avoid another ThemeProvider

Thanks for pointing out toMountPoint. I am going to close this PR and open a new one that just passes theme$ to toMountPoint.

Closing, replacing with #147270

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 22.3KB 22.4KB +67.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese added a commit that referenced this pull request Jan 10, 2023
Fixes #147147

Replaces #147151. Thanks for the
tip @Dosant

PR passes theme$ to toMountPoint

<img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM"
src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
…ic#147270)

Fixes elastic#147147

Replaces elastic#147151. Thanks for the
tip @Dosant

PR passes theme$ to toMountPoint

<img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM"
src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Drilldowns Embeddable panel Drilldowns release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Darktheme is missing from add drilldowns panel
5 participants