-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[drilldown] fix Darktheme is missing from add drilldowns panel #147151
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here toMountPoint
supports passing theme$
from core as part of config which is a second argument
Maybe better to use that to avoid another ThemeProvider
Lines 100 to 110 in 431c32b
toMountPoint( | |
<plugins.uiActionsEnhanced.DrilldownManager | |
closeAfterCreate | |
initialRoute={'/new'} | |
dynamicActionManager={embeddable.enhancements.dynamicActions} | |
triggers={triggers} | |
placeContext={{ embeddable }} | |
templates={templates} | |
onClose={close} | |
/> | |
), |
Same for editFlyout
@elasticmachine merge upstream |
Thanks for pointing out toMountPoint. I am going to close this PR and open a new one that just passes theme$ to toMountPoint. Closing, replacing with #147270 |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Fixes #147147 Replaces #147151. Thanks for the tip @Dosant PR passes theme$ to toMountPoint <img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM" src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png"> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…ic#147270) Fixes elastic#147147 Replaces elastic#147151. Thanks for the tip @Dosant PR passes theme$ to toMountPoint <img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM" src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png"> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Fixes #147147
PR wraps LazyDrilldownManager with KibanaThemeProvider to resolve dark theme issues in drilldown flyout.