Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Hit enter modal stays open on filter out of same rule by jumping to next rule. #115341

Closed
ghost opened this issue Oct 18, 2021 · 6 comments
Closed

[Security Solution]Hit enter modal stays open on filter out of same rule by jumping to next rule. #115341

ghost opened this issue Oct 18, 2021 · 6 comments
Assignees
@christineweng
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0

Comments

@ghost
Copy link

ghost commented Oct 18, 2021

Describe the bug
Hit enter modal stays open on filter out of same rule by jumping to next rule.

Build Details

Version: 8.0.0 local Master
Commit:9007199254740991

Steps

  • Go to Alerts Page
  • Take a Look for any two consecutive alert entries ( let say first 2 alert entries).
  • Click on Hit enter icon for First alert of the list.
  • Filter out this alert
  • Observed instead on closing of Hit Enter Icon modal , it get jumped to next consecutive alert and show the details of it

Actual
Hit enter modal stays open on filter out of same rule by jumping to next rule.

Expected
If the rule for which hit enter is modal was opened and then filter out then hit enter modal should also close

Screen-Cast

modal-open.mp4

logs

  • N/A
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Threat Hunting:Explore labels Oct 18, 2021
@manishgupta-qasource
Copy link

Reviewed & Assigned to @MadameSheema

@MadameSheema MadameSheema removed their assignment Oct 20, 2021
@michaelolo24
Copy link
Contributor

FYI - Related to this PR: #113419

This was referenced Feb 1, 2022
Closed
Closed
@MindyRS MindyRS added the Team:Threat Hunting Security Solution Threat Hunting Team label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24
Copy link
Contributor

Potential fix: elastic/eui#5781 (comment)

@christineweng christineweng mentioned this issue Nov 11, 2022
Merged
christineweng added a commit that referenced this issue Nov 16, 2022
@christineweng
[Security Solution][Bug] fix popover in t-grid (#145025)
05d1ff8 
This PR contains fixes for the following issues:

#### # 1 Popover overlaps flyout
- #139280
- #128235
#### # 2 Popover persists after clicking filter out
- #115341
#### # 3 Popover persists after clicking a button outside of popover
- #118844

## Background
Previously, a cell's popover remains open after clicking an action. In
many cases we want the popover to close upon clicking on a cell action.
EUI team addressed this by adding a `closeCellPopover` to a `ref` API.
- elastic/eui#5590

In T-grid, there are 2 types of cell actions: 
- Default cell actions such as filter in, filter out, add to timeline
and copy. `closeCellPopover` is not used.
- Formatted fields that have more information in the form of flyouts
(host name, user name, ip, etc.)
`closeCellPopover` prop is passed but currently not working as expected.

This PR contains fixes for: 
- Fixing `closeCellPopover` in T-grid body for formatted fields - fixes
# 1
- Adding `closeCellPopover` props in default cell actions - fixes # 2
and # 3

## # 1 - `closeCellPopover` in T-grid 

`dataGridRef.current?.closeCellPopover` was added and intended to close
any open popovers when a cell action is clicked. However, because it is
a mutable object, it is not being monitored in `columnsWithCellActions`.
When the page is initially loaded, `dataGridRef.current` remain as null
and it does not update until the page re-renders and `dataGridRef`
becomes non-null.
- After: popover closes properly


https://user-images.githubusercontent.com/18648970/201202326-ec657f78-c425-46a6-9356-f6e9ef1ab798.mov


## # 2 & # 3 Add `closeCellPopover` to default cell actions

- After: upon opening the expansion popover, clicking any options and
the popover will disappear


https://user-images.githubusercontent.com/18648970/201417542-063c514b-5474-4676-a747-a9401627c5e8.mov

- After: upon opening the expansion popover, clicking any options
outside and the popover will disappear


https://user-images.githubusercontent.com/18648970/201417678-7cf0fefa-f4a7-4a70-9a10-76b248323639.mov

Note for UX: although QA only flagged `filter out` and `add to
timeline`, for consistency's sake, the expansion popover will disappear
after clicking any of the cell actions, which includes `filter in` and
`copy`.
@ghost
Copy link
Author

ghost commented Nov 17, 2022

Hi @michaelolo24

we have validated this issue on 8.6.0 BC1 and found this issue to be fixed now ✔️ .

Build Details

Version: 8.6.0 BC1
Commit:50a7feb0a5eb068d3acccc49c83b9ccb6db6734f
Build:58392

Screen-Cast

karanbir.-.ec2-3-88-91-221.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2022-11-17.13-58-08.mp4

Hence we are closing this issue and adding QA:Validated to it.

thanks !!

@ghost ghost closed this as completed Nov 17, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 17, 2022
benakansara pushed a commit to benakansara/kibana that referenced this issue Nov 17, 2022
@christineweng @benakansara
[Security Solution][Bug] fix popover in t-grid (elastic#145025)
1709f20 
This PR contains fixes for the following issues:

#### # 1 Popover overlaps flyout
- elastic#139280
- elastic#128235
#### # 2 Popover persists after clicking filter out
- elastic#115341
#### # 3 Popover persists after clicking a button outside of popover
- elastic#118844

## Background
Previously, a cell's popover remains open after clicking an action. In
many cases we want the popover to close upon clicking on a cell action.
EUI team addressed this by adding a `closeCellPopover` to a `ref` API.
- elastic/eui#5590

In T-grid, there are 2 types of cell actions: 
- Default cell actions such as filter in, filter out, add to timeline
and copy. `closeCellPopover` is not used.
- Formatted fields that have more information in the form of flyouts
(host name, user name, ip, etc.)
`closeCellPopover` prop is passed but currently not working as expected.

This PR contains fixes for: 
- Fixing `closeCellPopover` in T-grid body for formatted fields - fixes
# 1
- Adding `closeCellPopover` props in default cell actions - fixes # 2
and # 3

## # 1 - `closeCellPopover` in T-grid 

`dataGridRef.current?.closeCellPopover` was added and intended to close
any open popovers when a cell action is clicked. However, because it is
a mutable object, it is not being monitored in `columnsWithCellActions`.
When the page is initially loaded, `dataGridRef.current` remain as null
and it does not update until the page re-renders and `dataGridRef`
becomes non-null.
- After: popover closes properly


https://user-images.githubusercontent.com/18648970/201202326-ec657f78-c425-46a6-9356-f6e9ef1ab798.mov


## # 2 & # 3 Add `closeCellPopover` to default cell actions

- After: upon opening the expansion popover, clicking any options and
the popover will disappear


https://user-images.githubusercontent.com/18648970/201417542-063c514b-5474-4676-a747-a9401627c5e8.mov

- After: upon opening the expansion popover, clicking any options
outside and the popover will disappear


https://user-images.githubusercontent.com/18648970/201417678-7cf0fefa-f4a7-4a70-9a10-76b248323639.mov

Note for UX: although QA only flagged `filter out` and `add to
timeline`, for consistency's sake, the expansion popover will disappear
after clicking any of the cell actions, which includes `filter in` and
`copy`.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christineweng christineweng

Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@MindyRS @andrew-goldstein @elasticmachine @michaelolo24 @MadameSheema @christineweng @kqualters-elastic @manishgupta-qasource