Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Hover Actions popover does not close when user clicks on an action. #139280

Closed
logeekal opened this issue Aug 23, 2022 · 3 comments
Closed

[Security Solution] Hover Actions popover does not close when user clicks on an action. #139280

logeekal opened this issue Aug 23, 2022 · 3 comments
Assignees
@christineweng
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0

Comments

@logeekal
Copy link
Contributor

logeekal commented Aug 23, 2022 •
edited
Loading

Describe the bug:
When a user clicks on host hover actions, a popover opens. Ideally, the popover should close, when any of the actions is clicked. But that does not happen.

It was noticed in this PR.

Kibana/Elasticsearch Stack version:
8.4.0

Steps to reproduce:

hover_actions_popover mov
@logeekal logeekal added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Aug 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@logeekal logeekal changed the title [Security Solution] Host Actions popover does not close when click on an action. [Security Solution] Hover Actions popover does not close when user clicks on an action. Aug 23, 2022
@MadameSheema MadameSheema added Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team labels Sep 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24 michaelolo24 added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed triage_needed labels Sep 6, 2022
@michaelolo24 michaelolo24 removed their assignment Sep 6, 2022
@christineweng christineweng mentioned this issue Nov 10, 2022
Merged
christineweng added a commit that referenced this issue Nov 16, 2022
@christineweng
[Security Solution][Bug] fix popover in t-grid (#145025)
05d1ff8 
This PR contains fixes for the following issues:

#### # 1 Popover overlaps flyout
- #139280
- #128235
#### # 2 Popover persists after clicking filter out
- #115341
#### # 3 Popover persists after clicking a button outside of popover
- #118844

## Background
Previously, a cell's popover remains open after clicking an action. In
many cases we want the popover to close upon clicking on a cell action.
EUI team addressed this by adding a `closeCellPopover` to a `ref` API.
- elastic/eui#5590

In T-grid, there are 2 types of cell actions: 
- Default cell actions such as filter in, filter out, add to timeline
and copy. `closeCellPopover` is not used.
- Formatted fields that have more information in the form of flyouts
(host name, user name, ip, etc.)
`closeCellPopover` prop is passed but currently not working as expected.

This PR contains fixes for: 
- Fixing `closeCellPopover` in T-grid body for formatted fields - fixes
# 1
- Adding `closeCellPopover` props in default cell actions - fixes # 2
and # 3

## # 1 - `closeCellPopover` in T-grid 

`dataGridRef.current?.closeCellPopover` was added and intended to close
any open popovers when a cell action is clicked. However, because it is
a mutable object, it is not being monitored in `columnsWithCellActions`.
When the page is initially loaded, `dataGridRef.current` remain as null
and it does not update until the page re-renders and `dataGridRef`
becomes non-null.
- After: popover closes properly


https://user-images.githubusercontent.com/18648970/201202326-ec657f78-c425-46a6-9356-f6e9ef1ab798.mov


## # 2 & # 3 Add `closeCellPopover` to default cell actions

- After: upon opening the expansion popover, clicking any options and
the popover will disappear


https://user-images.githubusercontent.com/18648970/201417542-063c514b-5474-4676-a747-a9401627c5e8.mov

- After: upon opening the expansion popover, clicking any options
outside and the popover will disappear


https://user-images.githubusercontent.com/18648970/201417678-7cf0fefa-f4a7-4a70-9a10-76b248323639.mov

Note for UX: although QA only flagged `filter out` and `add to
timeline`, for consistency's sake, the expansion popover will disappear
after clicking any of the cell actions, which includes `filter in` and
`copy`.
@ghost
Copy link

ghost commented Nov 17, 2022

Hi @christineweng
We have validated this issue on the latest 8.6.0-BC1 build and observed that the issue is fixed. Please find below the testing details:

Build Details:
VERSION: 8.6.0-BC1
BUILD: 58392
COMMIT: 50a7feb

Screen-Recording:

samrat.-.ec2-54-242-190-185.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2022-11-17.14-11-49.mp4

Hence, we are closing this issue and marking it as QA Validated.

cc: @MadameSheema
Thanks!

@ghost ghost closed this as completed Nov 17, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 17, 2022
benakansara pushed a commit to benakansara/kibana that referenced this issue Nov 17, 2022
@christineweng @benakansara
[Security Solution][Bug] fix popover in t-grid (elastic#145025)
1709f20 
This PR contains fixes for the following issues:

#### # 1 Popover overlaps flyout
- elastic#139280
- elastic#128235
#### # 2 Popover persists after clicking filter out
- elastic#115341
#### # 3 Popover persists after clicking a button outside of popover
- elastic#118844

## Background
Previously, a cell's popover remains open after clicking an action. In
many cases we want the popover to close upon clicking on a cell action.
EUI team addressed this by adding a `closeCellPopover` to a `ref` API.
- elastic/eui#5590

In T-grid, there are 2 types of cell actions: 
- Default cell actions such as filter in, filter out, add to timeline
and copy. `closeCellPopover` is not used.
- Formatted fields that have more information in the form of flyouts
(host name, user name, ip, etc.)
`closeCellPopover` prop is passed but currently not working as expected.

This PR contains fixes for: 
- Fixing `closeCellPopover` in T-grid body for formatted fields - fixes
# 1
- Adding `closeCellPopover` props in default cell actions - fixes # 2
and # 3

## # 1 - `closeCellPopover` in T-grid 

`dataGridRef.current?.closeCellPopover` was added and intended to close
any open popovers when a cell action is clicked. However, because it is
a mutable object, it is not being monitored in `columnsWithCellActions`.
When the page is initially loaded, `dataGridRef.current` remain as null
and it does not update until the page re-renders and `dataGridRef`
becomes non-null.
- After: popover closes properly


https://user-images.githubusercontent.com/18648970/201202326-ec657f78-c425-46a6-9356-f6e9ef1ab798.mov


## # 2 & # 3 Add `closeCellPopover` to default cell actions

- After: upon opening the expansion popover, clicking any options and
the popover will disappear


https://user-images.githubusercontent.com/18648970/201417542-063c514b-5474-4676-a747-a9401627c5e8.mov

- After: upon opening the expansion popover, clicking any options
outside and the popover will disappear


https://user-images.githubusercontent.com/18648970/201417678-7cf0fefa-f4a7-4a70-9a10-76b248323639.mov

Note for UX: although QA only flagged `filter out` and `add to
timeline`, for consistency's sake, the expansion popover will disappear
after clicking any of the cell actions, which includes `filter in` and
`copy`.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christineweng christineweng

Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@logeekal @elasticmachine @michaelolo24 @MadameSheema @christineweng