Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Support soft failures #169244

Open
jbudz opened this issue Oct 18, 2023 · 2 comments
Open

[ci] Support soft failures #169244

jbudz opened this issue Oct 18, 2023 · 2 comments
Labels
Team:Operations Team label for Operations Team

Comments

@jbudz
Copy link
Member

jbudz commented Oct 18, 2023

Soft failures allow step failures to not fail the entire build - https://buildkite.com/docs/pipelines/command-step

While these can be enabled in buildkite, our pull request comments still indicate a build failure causing confusion on whether a pull request is merge-able.

@jbudz jbudz added the Team:Operations Team label for Operations Team label Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni
Copy link
Contributor

delanni commented Oct 19, 2023

We had an intent for this in this PR, but we kind of got stuck: https://github.com/elastic/kibana-buildkite-build-bot/pull/3

jbudz added a commit that referenced this issue Oct 23, 2023
Currently operations does not have a good mechanism for communicating
soft failures, leading to confusion on pull requests. We're tracking
support for soft failures at
#169244.

For example, in #169309, it
doesn't makes sense for the author to be responsible for fixing
flakiness here, so we need to make it clear it can be ignored or find a
way to skip this step in similar situations.

This moves the cypress burn out of the base pull request pipeline,
behind the `ci:all-cypress-suites` and `ci:cypress-burn` labels. I'm
open to all improvements here, not sure this quite finds the right
balance between stability and noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants