-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard][Controls] Fix field truncation on EuiSelectable #170398
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
related: #168753 |
These components are used in Lens and Unified Search so I'll pick it up along these other ones 👌🏼 |
I am still on it, but I didn't notice any regression for field, value and dataview picker for unified search. Overall the performance is not ideal, with 6x slowdown on my CPU hitting a key is ~90ms but it doesn't get worse. On unrelated topic, the first two points cannot be implemented without changes from the eui because |
Thanks Marta, no problem then, we will need to make changes on our end cc @ThomThomson |
## Summary Solves 1/3 of #170398 After assessing with @teresaalvarezsoler we decided to wrap to 10 lines and autoexpand. (Ignore the missing 'x' in some filter pills, it was not impacted 🙏🏼 ) <img width="1479" alt="Screenshot 2023-11-10 at 11 20 32" src="https://github.com/elastic/kibana/assets/4283304/11da80df-92e2-4ea7-9efe-5e352bb95add"> <img width="396" alt="Screenshot 2023-11-10 at 11 20 08" src="https://github.com/elastic/kibana/assets/4283304/0b37f2c1-d736-4507-ae12-0f3f0a3b11f5"> <img width="980" alt="Screenshot 2023-11-10 at 11 19 58" src="https://github.com/elastic/kibana/assets/4283304/07dc61f6-92fa-4569-b5ee-011a9078006a"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…c#170941) ## Summary Solves 1/3 of elastic#170398 After assessing with @teresaalvarezsoler we decided to wrap to 10 lines and autoexpand. (Ignore the missing 'x' in some filter pills, it was not impacted 🙏🏼 ) <img width="1479" alt="Screenshot 2023-11-10 at 11 20 32" src="https://github.com/elastic/kibana/assets/4283304/11da80df-92e2-4ea7-9efe-5e352bb95add"> <img width="396" alt="Screenshot 2023-11-10 at 11 20 08" src="https://github.com/elastic/kibana/assets/4283304/0b37f2c1-d736-4507-ae12-0f3f0a3b11f5"> <img width="980" alt="Screenshot 2023-11-10 at 11 19 58" src="https://github.com/elastic/kibana/assets/4283304/07dc61f6-92fa-4569-b5ee-011a9078006a"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…he content (elastic#171573) ## Summary Fixes partially two remaining tasks from elastic#168753 Fixes partially dataview issue from elastic#170398 It stretches to maximum approximate 60 characters if any of the labels in the list is of this length. If the content doesn't need the container to stretch, it doesn't do it. <details> <summary> Field picker in Lens</summary> minimum width: <img width="445" alt="Screenshot 2023-11-21 at 15 56 03" src="https://github.com/elastic/kibana/assets/4283304/2f0f8482-bd00-4ec2-bbde-cbc4f3198eed"> auto-expanded width: <img width="575" alt="Screenshot 2023-11-21 at 15 58 22" src="https://github.com/elastic/kibana/assets/4283304/df7bab4d-0a08-4d49-8a91-9386eba15d93"> </details> <details> <summary>Layer data view picker in Lens</summary> <img width="376" alt="Screenshot 2023-11-21 at 16 01 17" src="https://github.com/elastic/kibana/assets/4283304/b8a98d83-dabc-49bd-a3cc-fc3856de6d3e"> <img width="455" alt="Screenshot 2023-11-21 at 15 58 09" src="https://github.com/elastic/kibana/assets/4283304/f2c5bde8-7a4a-485f-bf97-fc2179171e50"> <img width="615" alt="Screenshot 2023-11-21 at 15 56 27" src="https://github.com/elastic/kibana/assets/4283304/0574fc6c-69a3-44e9-9d48-8d427c1c5dba"> </details> <details> <summary>Data view picker in Unified Search</summary> <img width="341" alt="Screenshot 2023-11-21 at 16 00 29" src="https://github.com/elastic/kibana/assets/4283304/1c838ded-0dc5-4632-94e4-1d94586f667c"> <img width="441" alt="Screenshot 2023-11-21 at 15 58 04" src="https://github.com/elastic/kibana/assets/4283304/87e4f1c0-7922-4b94-a114-f23ece544395"> <img width="561" alt="Screenshot 2023-11-21 at 15 56 20" src="https://github.com/elastic/kibana/assets/4283304/3ea0f222-5241-4c5b-b00b-4311972754cc"> </details> <details> <summary> Data view picker in dashboard Create control flyout</summary> <img width="677" alt="Screenshot 2023-11-21 at 16 14 00" src="https://github.com/elastic/kibana/assets/4283304/0455b6ed-555d-4cff-9e34-0de377be6e04"> <img width="682" alt="Screenshot 2023-11-21 at 15 54 56" src="https://github.com/elastic/kibana/assets/4283304/2a67685c-379d-4c0b-bf56-dbf7c35b3bd4"> </details> <details> <summary> Unified search data view select component (tested in maps)</summary> <img width="570" alt="Screenshot 2023-11-22 at 14 38 25" src="https://github.com/elastic/kibana/assets/4283304/bb52ab22-626d-4556-b40c-c9bcc925f426"> </details> <details> <summary>Unified search field and value picker</summary> Adds `panelMinWidth`, removes the custom flex width change behavior <img width="1142" alt="Screenshot 2023-11-22 at 14 40 26" src="https://github.com/elastic/kibana/assets/4283304/2450957f-38b7-4a73-b531-7acb29cb56bc"> https://github.com/elastic/kibana/assets/4283304/f4f33624-9287-403e-8472-81f705440f97 </details> <details> <summary> Discover breakdown field</summary> Removes the focus stretching and instead uses the panelMinWidth prop <img width="419" alt="Screenshot 2023-11-21 at 16 46 50" src="https://github.com/elastic/kibana/assets/4283304/e35125ad-8823-4bff-954b-8119a352829c"> <img width="619" alt="Screenshot 2023-11-21 at 16 48 20" src="https://github.com/elastic/kibana/assets/4283304/89e63daf-a59e-43e1-a6ec-91d1b15b0fcd"> </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…ta view pickers and field lists (#172296) Adds middle truncation to the following: Fixes #168753 Fixes #170398 Unified Search: <img width="554" alt="Screenshot 2023-11-30 at 16 06 49" src="https://github.com/elastic/kibana/assets/4283304/38d95de5-78d3-4c33-8287-897876422886"> Lens layer data view picker: <img width="620" alt="Screenshot 2023-11-30 at 16 06 58" src="https://github.com/elastic/kibana/assets/4283304/68c6f0d6-7496-4db9-a0c0-0596350a4e90"> Create control field list: <img width="843" alt="Screenshot 2023-11-30 at 16 15 12" src="https://github.com/elastic/kibana/assets/4283304/7ac4fb32-bdd4-44b0-ab49-2967e3d54fe2"> Create control data view list: <img width="584" alt="Screenshot 2023-11-30 at 16 33 10" src="https://github.com/elastic/kibana/assets/4283304/a3b53c24-c363-4d72-b3e2-d4073ae4b3cf">
We can update the UX in kibana to take advantage of the auto-expansion capabilities.
The below suggested solutions are a best-guess, will require some tinkering to see what looks best (use o11y data to test)
The text was updated successfully, but these errors were encountered: